Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Render typing notification #2267

Closed
3 tasks done
bmarty opened this issue Jan 12, 2024 · 2 comments
Closed
3 tasks done

[Story] Render typing notification #2267

bmarty opened this issue Jan 12, 2024 · 2 comments

Comments

@bmarty
Copy link
Member

bmarty commented Jan 12, 2024

Description

  • As a member of a room viewing the timeline, I want to see when one or several other users are typing a message so that I can expect a new message from them.

  • No typing notification is displayed when the user is on the room list.

Rust implementation: matrix-org/matrix-rust-sdk#3059. Not that Rust does not filter out the current user (and I think this is fine), the filtering has to be done on the app side.

Figma: https://www.figma.com/file/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?type=design&node-id=254%3A49852&mode=design&t=LUBT4dAoV6qjfqV9-1 Still need to take a decision about how the scrolling will behave.

Strings have been added to Localay with the prefix screen_room_typing_:

  <plurals name="screen_room_typing_many_members">
    <item quantity="one">"%1$s, %2$s and %3$d other"</item>
    <item quantity="other">"%1$s, %2$s and %3$d others"</item>
  </plurals>
  <plurals name="screen_room_typing_notification">
    <item quantity="one">"%1$s is typing"</item>
    <item quantity="other">"%1$s are typing"</item>
  </plurals>
  <string name="screen_room_typing_two_members">"%1$s and %2$s"</string>

This should be enough to cover all the cases, and do a proper formatting, but let me know if there are any questions.

Acceptance criteria

  • When one or several people are typing a message in a room, I can see it in the timeline.

Size estimate

None

Dependencies

  • We need some design to decide how we can render the typing notification in the timeline.

Out of scope

  • Nothing

Open questions

Questions

No tasks being tracked yet.

Subtasks

Android

  1. A-Typing T-Task

iOS

  1. A-Typing T-Task
    stefanceriu

Rust

Other

No tasks being tracked yet.
@bmarty
Copy link
Member Author

bmarty commented Jan 26, 2024

We have some design here: https://www.figma.com/file/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?type=design&node-id=254%3A49852&mode=design&t=LUBT4dAoV6qjfqV9-1

We still need to decide how the typing notification will scroll.

image

@bmarty
Copy link
Member Author

bmarty commented Feb 9, 2024

The typing notification will scroll like a message (so it's like a regular timeline item).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants