Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication that user list is loading when inviting to room #1950

Closed
2 tasks done
kittykat opened this issue Jul 19, 2023 · 7 comments
Closed
2 tasks done

No indication that user list is loading when inviting to room #1950

kittykat opened this issue Jul 19, 2023 · 7 comments

Comments

@kittykat
Copy link
Contributor

kittykat commented Jul 19, 2023

Steps to reproduce

  1. Go to room -> room detail -> "Invite people"
  2. Start typing username
  3. Click "search"

Outcome

What did you expect?

Instantly see results

What happened instead?

First time it took a minute to see the exact match

Your phone model

Pixel 6a

Operating system version

Graphene OS

Application version and app store

Nightly

Homeserver

matrix.org

Will you send logs?

No

Are you willing to provide a PR?

No

Tasks

  1. A-Invite T-Task
    ganfra
@kittykat
Copy link
Contributor Author

kittykat commented Aug 2, 2023

Also do not get told that the search can't happen when in airplane mode/offline

@kittykat kittykat transferred this issue from element-hq/element-x-android Aug 2, 2023
@amshakal
Copy link

amshakal commented Aug 9, 2023

We should probably have a spinner if results are loading

@manuroe
Copy link
Member

manuroe commented Jan 3, 2024

iOS spinner:

RPReplay_Final1704277710.MP4

@ganfra
Copy link
Member

ganfra commented Jan 3, 2024

So we don't show the spinner before we have the minimal number of chars in the query (3 at the moment)?
Also if the query is a userId, we are showing a fake result, but we are also searching for more results. So should the spinner be shown in those cases too?

@amshakal
Copy link

amshakal commented Jan 4, 2024

I dont think we show spinner on iOS before 3 characters as well, so we can use the same pattern on android. I think if are searching for more results, we should show the spinner.

@claell
Copy link

claell commented Jan 10, 2024

After implementing #2172, does this still need other implementations, or can this be closed?

@manuroe
Copy link
Member

manuroe commented Feb 15, 2024

Sure, we can can close it.

@manuroe manuroe closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants