Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad missing posthog events #1783

Closed
2 tasks done
VolkerJunginger opened this issue Jun 15, 2023 · 4 comments
Closed
2 tasks done

Ad missing posthog events #1783

VolkerJunginger opened this issue Jun 15, 2023 · 4 comments
Assignees

Comments

@VolkerJunginger
Copy link
Contributor

VolkerJunginger commented Jun 15, 2023

A story should take roughly a week or a sprint to finish. Each story is usually made up of a number of tasks that take half to a full day.

The following posthog events are needed for the EX dashboard.

composer

  • isEditing
  • is reply

ViewRoom

  • isDM

CreatedRoom

  • isDM

JoinedRoom

  • isDM

screen

  • screenName
  • durationMs

Tasks

@giomfo
Copy link
Member

giomfo commented Jun 15, 2023

@VolkerJunginger I have 2 questions:

  • what do you expect exactly about isDM boolean? should we keep the legacy way to decide if a room is a DM, or do you expect a change? I heard that we plan to limit DM to the 2 members rooms, but perhaps this is too early to change the conditions to be a direct (This question is mainly about ViewRoom where we can check members number)
  • can you confirm the last one is MobileScreen? FYI we will use first the existing screenName defined here.

@VolkerJunginger
Copy link
Contributor Author

Treat isDM the same we have in the other apps.

@giomfo
Copy link
Member

giomfo commented Jun 19, 2023

@VolkerJunginger FYI I checked with @yostyle and @nimau the existing Analytics implementation. It seems that durationMs is not available for the Screen event for the moment. It was not sent in the Legacy app at least for the code we checked. So we will not probably include this duration in our commits for this task

@nimau
Copy link

nimau commented Jun 21, 2023

For the JoinedRoom event, the room size is calculated using the activeMembersCount room property available in the RustSDK.
The activeMembersCount is the number of members who have joined or been invited to the room.

Note: in the legacy Element-iOS, this room size was considering only joined members. We consider more relevant to include the invited members

@yostyle

@giomfo giomfo closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants