Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages sent from verified session marked as un-verified #1990

Open
matrixbot opened this issue Nov 1, 2024 · 4 comments
Open

Messages sent from verified session marked as un-verified #1990

matrixbot opened this issue Nov 1, 2024 · 4 comments
Labels
e2ee This issue or PR affects End-to-End Encryption on clients

Comments

@matrixbot
Copy link
Collaborator

This issue was originally created by @alistair23 at matrix-org/dendrite#1990.

Background information

  • Dendrite version or git SHA: 037ff4f
  • Monolith or Polylith?: Monolith
  • SQLite3 or Postgres?: Postgres
  • Running in Docker?: No
  • go version: 1.15.6

Description

I setup cross signing in Element and I can chat to others via encrypted rooms with everything working correctly.

I then sign in on the lastest build of Nheko. I then manually verify the Nheko device in Element so that it is treated as verified.

When I send a message from Nheko it still flags to other users as sent from an unverified session.

Looking at the device_id in the message I see it was sent from my verified Nheko instance.

I don't see anything interesting in the log to indicate an error

Steps to reproduce

  • Verify a Nheko instance
  • Send an encrypted message.
@matrixbot matrixbot added the e2ee This issue or PR affects End-to-End Encryption on clients label Nov 1, 2024
@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @kegsay at matrix-org/dendrite#1990 (comment).

Cross-signing is not fully implemente over federation as per:

  Cross-signing Keys       :  75% (6/8 tests)
    ✓ Can upload self-signing keys
    ✓ Fails to upload self-signing keys with no auth
    ✓ Fails to upload self-signing key without master key
    ✓ Changing master key notifies local users
    ✓ Changing user-signing key notifies local users
    ✓ can fetch self-signing keys over federation
    × uploading self-signing key notifies over federation
    × uploading signed devices gets propagated over federation

Was the person you were trying to talk to on a different server?

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @alistair23 at matrix-org/dendrite#1990 (comment).

Yes, they were on a different server

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @kegsay at matrix-org/dendrite#1990 (comment).

This has been 100% for some time now:

Cross-signing Keys       : 100% (8/8 tests)
      ✅ Can upload self-signing keys
      ✅ Fails to upload self-signing keys with no auth
      ✅ Fails to upload self-signing key without master key
      ✅ Changing master key notifies local users
      ✅ Changing user-signing key notifies local users
      ✅ can fetch self-signing keys over federation
      ✅ uploading self-signing key notifies over federation
      ✅ uploading signed devices gets propagated over federation

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @kegsay at matrix-org/dendrite#1990 (comment).

I'm assuming that the Element instance was Element-Web. If so, you may have hit element-hq/element-web#21919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2ee This issue or PR affects End-to-End Encryption on clients
Projects
None yet
Development

No branches or pull requests

1 participant