Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Fix Dependency Vulnerability #11

Closed
wants to merge 2 commits into from
Closed

Fix Dependency Vulnerability #11

wants to merge 2 commits into from

Conversation

AstroGD
Copy link

@AstroGD AstroGD commented Jan 30, 2019

decompress-zip has a vulnerability with high risk (Arbitrary File overwrite)
To fix this an update is mandatory

fixes #10
fixes electron/asar#163

decompress-zip has a vulnerability with high risk (Arbitrary File overwrite)
To fix this an update is mandatory
@@ -23,7 +23,7 @@
"rimraf": "~2.1.4"
},
"dependencies": {
"decompress-zip": "0.3.2",
"decompress-zip": "^0.3.2",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is made so that upcoming updates >= 0.3.2 <0.4.0 will automatically be installed

@nucleardreamer
Copy link

I was just coming to this repo to make this exact same PR. Thanks for doing it @AstroGD !

@y0x
Copy link

y0x commented Feb 4, 2019

Same here, but it seems that this package is no longer maintained?!

@jameskerr
Copy link

I need this fix as well. Thanks for the work to update it. Hope it gets merged soon.

@e2jk
Copy link

e2jk commented Feb 8, 2019

@zeke , @kevinsawicki , is there any hope to get this PR merged for this inactive package?
It is currently an indirect dependency of electron-packager (electron-packager > asar > mksnapshot > decompress-zip), all projects using electron-packager now have a "high severity vulnerability" being detected by npm audit.
(Note that @bizob2828 also logged an issue against asar to remove the dependency leading to this)

@bizob2828
Copy link

bizob2828 commented Feb 11, 2019

Not sure if anyone cares, but I bit the bullet and forked the relevant repos. I didn't publish to npm as I hope this will eventually get resolved but you can just npm install Contrast-Security-OSS/asar#v0.14.8

@AstroGD
Copy link
Author

AstroGD commented Feb 12, 2019

@bizob2828 Thanks for the effort. Ill try using your version of asar as long as there is no official fix. Did you create a PR for your fixed version at the asar Repo?

@AstroGD
Copy link
Author

AstroGD commented Mar 20, 2019

It seems this PR is no longer needed as there was an update on this repo, that updated the dependencies.
(Im referring to this commit: 90d0956 )

@AstroGD AstroGD closed this Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix security issue by updating decompress-zip Remove dependency on an achived package node-mksnapshot
6 participants