Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

WebSocket and host-rules Switch #74

Open
jhleath opened this issue Sep 6, 2014 · 0 comments
Open

WebSocket and host-rules Switch #74

jhleath opened this issue Sep 6, 2014 · 0 comments

Comments

@jhleath
Copy link

jhleath commented Sep 6, 2014

I am grateful for you adding support for the --host-rules command line switch; however, the addition of this tag seems to have introduced errors involving the resolution of websockets (ws://) domains.

It appears as though when the host rules switch is active for a domain, websockets requests to that domain never complete (they stay pending forever, without contacting the server). I have concluded that they cannot successfully resolve the name.

I have experimented with Atom-Shell and Chrome proper, and Chrome will correctly handle the websockets request with the host-rules flag, while Atom-Shell will only load the websocket if it doesn't include the host-rules url (i.e. switching to xip.io). Thanks for all your help!

@zcbenz zcbenz added the bug label Oct 23, 2014
@stale stale bot added the wontfix label Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants