Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6 add more validations for the config file #7

Merged
merged 2 commits into from
Mar 1, 2024
Merged

#6 add more validations for the config file #7

merged 2 commits into from
Mar 1, 2024

Conversation

gluckzhang
Copy link
Member

No description provided.

@gluckzhang gluckzhang mentioned this pull request Mar 1, 2024
Closed
Ebaneck
Ebaneck reviewed Mar 1, 2024
View reviewed changes
main.py Outdated Show resolved Hide resolved
Ebaneck
Ebaneck reviewed Mar 1, 2024
View reviewed changes
main.py Outdated Show resolved Hide resolved
Ebaneck
Ebaneck reviewed Mar 1, 2024
View reviewed changes
main.py Outdated Show resolved Hide resolved
Ebaneck
Ebaneck reviewed Mar 1, 2024
View reviewed changes
Copy link

@Ebaneck Ebaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few typos here and there!

@gluckzhang gluckzhang merged commit 1193720 into main Mar 1, 2024
2 checks passed
@gluckzhang
Copy link
Member Author

LGTM, just a few typos here and there!

Perfect. Thank you @Ebaneck :)

@gluckzhang gluckzhang deleted the 6/add-more-config-file-validations branch March 1, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ebaneck Ebaneck Ebaneck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gluckzhang @Ebaneck