Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Immutability/Customization - updates - milestone 3 #5888

Open
ARWNightingale opened this issue Oct 4, 2024 · 2 comments
Open

Rule Immutability/Customization - updates - milestone 3 #5888

ARWNightingale opened this issue Oct 4, 2024 · 2 comments
Assignees
Labels

Comments

@ARWNightingale
Copy link

ARWNightingale commented Oct 4, 2024

Description

We are introducing Elastic rules that can be modified by the user, this enables the rules to be updated but take into account of the users modified fields. We will offer reviewing the updates of fields in the modified rules for the user to accept or change as they see fit before accepting the whole update.

We would like to review some of the copy we are suggesting:

  1. Elastic rules that have been changed/customised by the user will be known as elastic rules still but have a tag as modified.
    Image

  2. New feature call out on installed rules / update page, we require help on the copy for this.

  • Show if the Elastic rule is modified but having a badge next to the name on the installed table.
    Image
  1. In the review flyout for unmodified rules we have a message" Update accepted - Auto accept applied as field has no conflicts." do users know what a field is? is there something else we could say.
    Image

  2. For modified elastic rules we have this flyout for conflicts that have been solved. we would like to review the callout message and each field message in the header of the field.
    Image

  3. For modified elastic rules we have this flyout for conflicts that can not be resolved. we would like to review the callout message and each field message in the header of the field.
    Image

  4. For modified elastic rules we have this flyout for both types of solved and unsolved conflicts. we would like to review the callout message.
    Image

  5. When the user has accepted all the fields updates then the call out changes to a success message telling the user he can not update the rule.
    Image

8)General advise on Solved conflict, Unsolved conflict, auto accepted terminology would be great too.

Thanks

Related links / assets

Please include each of the following, if applicable:
Figma link(s):

Github epic link(s): 1974

Miro board for flyout editing

Which documentation set does this change impact?

ESS and serverless

Feature differences

The feature is identical in both

Software version

8:18? confirming with Kseniia

Collaborators

PM: @approksiu
Designer: @ARWNightingale
Developer:
Others (if applicable):

Timeline / deliverables

We are currently working on the UI so as soon as you could please.

@ARWNightingale
Copy link
Author

ARWNightingale commented Oct 15, 2024

Hey @nastasha-solomon, We have had some small amend due to scope reduction. I have a amended it in the epic story and heres the summary below:
Update table
-Support filtering by "Modified rules" and "Unmodified rules" in the update rules table using a new dropdown filer.

  • No facet search
    Image

Installed rules page:

  • Keep existing filtering with existing options of Elastic rules and Custom rules.

  • Show if the Elastic rule is modified but having a badge on the rule details page and installed table.

  • Image

@ARWNightingale
Copy link
Author

Hey @joepeeples just a small change here we have now removed the column of modified and just kept a badge next to the rule name as an iteration before we have facet search capabilities. designs above have been amended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants