Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Buildkite to preview links GitHub action #4313

Closed
18 tasks done
joepeeples opened this issue Nov 27, 2023 · 2 comments
Closed
18 tasks done

Add Buildkite to preview links GitHub action #4313

joepeeples opened this issue Nov 27, 2023 · 2 comments
Assignees
@joepeeples
Labels
Effort: Medium Issues that take moderate but not substantial time to complete Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Docs

Comments

@joepeeples
Copy link
Contributor

joepeeples commented Nov 27, 2023 •
edited
Loading

Description

Per elastic/docs#2837 (comment), our PRs will start using Buildkite to generate previews but we'll need to revise our GitHub action (docs-preview-links.yml) to provide the URLs to those previews.

ℹ️ TIP: Follow elastic/docs#2843, which looks to provide a common GitHub action template that all docs teams can use...

Tasks
Preview Give feedback

Backport PRs
Preview Give feedback
  1. [7.17] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4421
    backport
  2. [8.0] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4430
    backport
  3. [8.1] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4429
    backport
  4. [8.2] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4428
    backport
  5. [8.3] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4427
    backport
  6. [8.4] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4426
    backport
  7. [8.5] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4425
    backport
  8. [8.6] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4424
    backport
  9. [8.7] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4423
    backport
  10. [8.8] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4422
    backport
  11. [8.9] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4420
    backport
  12. [8.10] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4419
    backport
  13. [8.11] Add Buildkite preview links to PRs (#4390) | Delete docs-preview-links.yml (#4406) #4418
    backport
@joepeeples joepeeples self-assigned this Nov 27, 2023
@nkammah
Copy link
Contributor

nkammah commented Nov 29, 2023 •
edited
Loading

@joepeeples you can indeed use the generic action by defining a workflow like this once elastic/docs#2843 is merged.

Comm is on its way.

This was referenced Dec 5, 2023
Merged
Merged
@joepeeples joepeeples added Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Medium Issues that take moderate but not substantial time to complete labels Dec 6, 2023
@joepeeples
Copy link
Contributor Author

Backporting to all of 8.x to help with anticipated image cleanup efforts. Also backporting 7.17 to catch the most recent 7.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joepeeples joepeeples

Labels
Effort: Medium Issues that take moderate but not substantial time to complete Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkammah @joepeeples