Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the description of new_terms_fields in Create rule and Update rule API docs #3987

Closed
natasha-moore-elastic opened this issue Sep 21, 2023 · 0 comments · Fixed by #3994
Closed

Modify the description of new_terms_fields in Create rule and Update rule API docs #3987

natasha-moore-elastic opened this issue Sep 21, 2023 · 0 comments · Fixed by #3994
Assignees
@natasha-moore-elastic
Labels
Effort: Small Issues that can be resolved quickly Feature: Rules Priority: Medium Issues that have relevance, but aren't urgent Team: Detection Engine v8.4.0 v8.5.0

Comments

@natasha-moore-elastic
Copy link
Contributor

In #3914 the new terms rule type was added to Detections API create and update rule docs. The new terms rule type was introduced in 8.4 (elastic/kibana#134526).
Support for multiple values in new_terms_fields was added in 8.6 (elastic/kibana#143943), so we should modify the description of this field (currently 'Must contain 1-3 field names') to reflect the limitation (something like 'Must contain 1 field name'), and backport this change to 8.4 and 8.5 only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natasha-moore-elastic natasha-moore-elastic

Labels
Effort: Small Issues that can be resolved quickly Feature: Rules Priority: Medium Issues that have relevance, but aren't urgent Team: Detection Engine v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modifies description of new_terms_fields elastic/security-docs
1 participant
@natasha-moore-elastic