Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Support for bulk upload API #406

Open
Tracked by #346
majagrubic opened this issue Sep 6, 2022 · 4 comments
Open
Tracked by #346

[Discuss] Support for bulk upload API #406

majagrubic opened this issue Sep 6, 2022 · 4 comments
Labels
discuss Issue needs discussion Team:Ecosystem Label for the Packages Ecosystem team

Comments

@majagrubic
Copy link

As you may know, the shared-ux team is working on sample data re-architecture, and we'd like to leverage EPR for that. (Previous discussion here). Right now, sample data is a (gzipped) json file with Elasticsearch documents that are then bulk-uploaded to ES when a user requests an install.
If we were to add a new integration that would contain this sample data, what is the best way to make the bulk upload work?

cc @joshdover

@majagrubic majagrubic added the discuss Issue needs discussion label Sep 6, 2022
@jlind23 jlind23 added the Team:Ecosystem Label for the Packages Ecosystem team label Sep 6, 2022
@majagrubic majagrubic changed the title [Discuss] Support for bulk upload to API [Discuss] Support for bulk upload API Sep 6, 2022
@majagrubic
Copy link
Author

majagrubic commented Sep 13, 2022

As discussed in the call today, we would also need to add support for a new package type that would be "asset only" or something similar. Let me know if you want me to open a new issue to discuss that, or can we use this issue to coordinate.

@jsoriano
Copy link
Member

I have added this issue to the implementation plan in #346. I think we can continue there.

@jen-huang
Copy link
Contributor

My initial thinking is that we can do something very similar to what sample data does today - perhaps we can even re-purpose the existing code.

That assumes that we are ok with storing archive files on the registry. @jsoriano the other discussion threads are a bit long - do you think that is ok?

This means that the package-spec will need to define enough information for Fleet to know that filexyz.gzip contains ES documents and should be handled as such.

@kpollich, WDYT?

@jsoriano
Copy link
Member

That assumes that we are ok with storing archive files on the registry. @jsoriano the other discussion threads are a bit long - do you think that is ok?

This means that the package-spec will need to define enough information for Fleet to know that filexyz.gzip contains ES documents and should be handled as such.

Yes, if we distribute these files through the registry, their format must be defined in the package-spec. This would be aligned with the implementation plan in the description of #346, that summarizes the discussion threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs discussion Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

No branches or pull requests

4 participants