From 400539f31ef695608f4260567812abe18d0ba022 Mon Sep 17 00:00:00 2001 From: Sergi Romeu Date: Thu, 21 Nov 2024 16:59:25 +0100 Subject: [PATCH 1/3] refactor: remove actions tooltip --- .../public/components/entities_grid/grid_columns.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/grid_columns.tsx b/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/grid_columns.tsx index be5c50eba9c07..867425b9e0aed 100644 --- a/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/grid_columns.tsx +++ b/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/grid_columns.tsx @@ -116,9 +116,7 @@ export const getColumns = ({ id: 'actions' as const, // keep it for accessibility purposes displayAsText: entityActionsLabel, - display: ( - - ), + display: {entityActionsLabel}, initialWidth: 100, }, ] From 5e635ccee7a75975ed8e146cc8ef82d9c35b4805 Mon Sep 17 00:00:00 2001 From: Sergi Romeu Date: Thu, 21 Nov 2024 17:15:56 +0100 Subject: [PATCH 2/3] chore: fix small typo --- .../inventory/public/components/entities_grid/index.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx b/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx index ff4329955773d..dd421d30a3a9c 100644 --- a/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx +++ b/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx @@ -160,7 +160,7 @@ export function EntitiesGrid({ @@ -169,10 +169,10 @@ export function EntitiesGrid({ ), total: entities.length, - boldEntites: ( + boldEntities: ( {i18n.translate( - 'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites', + 'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities', { defaultMessage: 'Entities' } )} From 6f2e28f9abda953bdad3212e8797e037acecb99c Mon Sep 17 00:00:00 2001 From: Sergi Romeu Date: Fri, 22 Nov 2024 11:15:49 +0100 Subject: [PATCH 3/3] fix: fix translations typo --- x-pack/plugins/translations/translations/fr-FR.json | 4 ++-- x-pack/plugins/translations/translations/ja-JP.json | 4 ++-- x-pack/plugins/translations/translations/zh-CN.json | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json index f64646a2bf3d2..363611d2cd048 100644 --- a/x-pack/plugins/translations/translations/fr-FR.json +++ b/x-pack/plugins/translations/translations/fr-FR.json @@ -26180,8 +26180,8 @@ "xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "Le nombre d'alertes actives", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "Nom de l'entité", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "Nom de l'entité (entity.displayName)", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntites}", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "Entités", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntities}", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "Entités", "xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "Grille des entités d'inventaire", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} à {time}", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "Vu en dernier", diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index cb39940e6ffb6..606540e5eb516 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -26152,8 +26152,8 @@ "xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "アクティブなアラートの件数", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "エンティティ名", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "エンティティの名前（entity.displayName）", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntites}を表示中", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "エンティティ", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntities}を表示中", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "エンティティ", "xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "インベントリエンティティグリッド", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "前回の認識", diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index 150003b98dd48..2d66abe9e691d 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -25682,8 +25682,8 @@ "xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "活动告警计数", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "实体名称", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "实体的名称 (entity.displayName)", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个（共 {total} 个）{boldEntites}", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "实体", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个（共 {total} 个）{boldEntities}", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "实体", "xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "库存实体网格", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "最后看到时间",