From cc1bdebed03c7358147fe507b0821eb00e6382a7 Mon Sep 17 00:00:00 2001 From: Jordan McAlpine <128929391+mickalpine@users.noreply.github.com> Date: Wed, 20 Nov 2024 15:24:58 -0500 Subject: [PATCH] fix: kibana dev server not restarting for external plugin #171260 (#198246) ## Summary Fixes #171260 the Kibana dev server not restarting during external plugin development for server side code. ### Checklist ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes #171260 the Kibana dev server not restarting during external plugin development for server side code. --------- Co-authored-by: Brad White (cherry picked from commit 83b282a63a3748a07a0d9e69f2cafa44b9439af7) --- packages/kbn-cli-dev-mode/src/watcher.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/kbn-cli-dev-mode/src/watcher.ts b/packages/kbn-cli-dev-mode/src/watcher.ts index 3c9763e0543aa..6dc11371d9582 100644 --- a/packages/kbn-cli-dev-mode/src/watcher.ts +++ b/packages/kbn-cli-dev-mode/src/watcher.ts @@ -26,7 +26,8 @@ const packageMatcher = makeMatcher([ /** * Any code that is outside of a package must match this in order to trigger a restart */ -const nonPackageMatcher = makeMatcher(['config/**/*.yml']); +const nonPackageMatcher = makeMatcher(['config/**/*.yml', 'plugins/**/server/**/*']); +const staticFileMatcher = makeMatcher(['plugins/**/kibana.json']); export interface Options { enabled: boolean; @@ -87,6 +88,10 @@ export class Watcher { if (result.type === 'non-package') { return nonPackageMatcher(result.repoRel) && fire(result.repoRel); } + + if (result.type === 'static') { + return staticFileMatcher(result.repoRel) && fire(result.repoRel); + } } }, {