Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Cases] Fixed sync alerts switch flaky tests #200738

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Nov 19, 2024

Fixes #192997

Summary

I removed createAppMockRenderer because SyncAlertsSwitch is a really simple component.

@adcoelho adcoelho added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 Feature:Cases Cases feature backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 19, 2024
@adcoelho adcoelho self-assigned this Nov 19, 2024
@adcoelho adcoelho requested a review from a team as a code owner November 19, 2024 14:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @adcoelho

@adcoelho adcoelho merged commit d94f800 into elastic:main Nov 20, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11930004695

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
…200738)

Fixes elastic#192997

## Summary

I removed `createAppMockRenderer` because `SyncAlertsSwitch` is a really
simple component.

(cherry picked from commit d94f800)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 20, 2024
… tests (#200738) (#200865)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Cases] Fixed `sync alerts switch` flaky tests
(#200738)](#200738)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T09:00:18Z","message":"[ResponseOps][Cases]
Fixed `sync alerts switch` flaky tests (#200738)\n\nFixes
#192997\r\n\r\n## Summary\r\n\r\nI removed `createAppMockRenderer`
because `SyncAlertsSwitch` is a really\r\nsimple
component.","sha":"d94f8008a6b15da0358dd72b5897efe9b9e217e4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor"],"title":"[ResponseOps][Cases]
Fixed `sync alerts switch` flaky
tests","number":200738,"url":"https://github.com/elastic/kibana/pull/200738","mergeCommit":{"message":"[ResponseOps][Cases]
Fixed `sync alerts switch` flaky tests (#200738)\n\nFixes
#192997\r\n\r\n## Summary\r\n\r\nI removed `createAppMockRenderer`
because `SyncAlertsSwitch` is a really\r\nsimple
component.","sha":"d94f8008a6b15da0358dd72b5897efe9b9e217e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200738","number":200738,"mergeCommit":{"message":"[ResponseOps][Cases]
Fixed `sync alerts switch` flaky tests (#200738)\n\nFixes
#192997\r\n\r\n## Summary\r\n\r\nI removed `createAppMockRenderer`
because `SyncAlertsSwitch` is a really\r\nsimple
component.","sha":"d94f8008a6b15da0358dd72b5897efe9b9e217e4"}}]}]
BACKPORT-->

Co-authored-by: Antonio <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
…200738)

Fixes elastic#192997

## Summary

I removed `createAppMockRenderer` because `SyncAlertsSwitch` is a really
simple component.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…200738)

Fixes elastic#192997

## Summary

I removed `createAppMockRenderer` because `SyncAlertsSwitch` is a really
simple component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.17.0 v9.0.0
Projects
None yet
4 participants