From 4267f29c40ebea7289e37174fc65d30180c5e6dc Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Fri, 1 Nov 2024 07:48:45 -0700 Subject: [PATCH 01/14] re-enabled 'transaction-details' tests --- .../cypress/e2e/transaction_details/transaction_details.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts index 730e9c443854e..0fc1b609b14ba 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts @@ -16,7 +16,7 @@ const timeRange = { rangeTo: end, }; // flaky -describe.skip('Transaction details', () => { +describe('Transaction details', () => { before(() => { synthtrace.index( opbeans({ From 91dd8abc417a5deed2af6e1c7d3dcb0bb2b8368a Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Thu, 7 Nov 2024 14:21:32 -0800 Subject: [PATCH 02/14] bumped timeout for 'show top errors table' from 30s -> 60s --- .../cypress/e2e/transaction_details/transaction_details.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts index 0fc1b609b14ba..9dfbd2e31c76e 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts @@ -114,7 +114,7 @@ describe('Transaction details', () => { })}` ); - cy.contains('Top 5 errors', { timeout: 30000 }); + cy.contains('Top 5 errors', { timeout: 60000 }); cy.getByTestSubj('topErrorsForTransactionTable').contains('a', '[MockError] Foo').click(); cy.url().should('include', 'opbeans-java/errors'); }); From 756a5490b553563c00f4f19e107a82d2a6eb56e5 Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Thu, 7 Nov 2024 15:56:24 -0800 Subject: [PATCH 03/14] added addtional timeout duration --- .../cypress/e2e/transaction_details/transaction_details.cy.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts index 9dfbd2e31c76e..bfec80ad3296f 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts @@ -115,7 +115,9 @@ describe('Transaction details', () => { ); cy.contains('Top 5 errors', { timeout: 60000 }); - cy.getByTestSubj('topErrorsForTransactionTable').contains('a', '[MockError] Foo').click(); + cy.getByTestSubj('topErrorsForTransactionTable') + .contains('a', '[MockError] Foo', { timeout: 60000 }) + .click(); cy.url().should('include', 'opbeans-java/errors'); }); From 75f45711d4d54efd5d5e33c5262b8cb1bc22f071 Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Fri, 8 Nov 2024 08:53:32 -0800 Subject: [PATCH 04/14] increased timout and re-enabled integration_policy.cy.ts --- .../cypress/e2e/integration_settings/integration_policy.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts index 753e6476be1ed..07a6b5740112a 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts @@ -37,7 +37,7 @@ describe.skip('when navigating to integration page', () => { // open integration policy form cy.getByTestSubj('integration-card:ui_link:apm').click(); - cy.contains('Elastic APM in Fleet').click(); + cy.contains('Elastic APM in Fleet', { timeout: 60000 }).click(); cy.contains('a', 'APM integration').click(); cy.getByTestSubj('addIntegrationPolicyButton').click(); }); From 0b689e8c253a5c99a7f761ece7bee369f8b2d0f6 Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Fri, 8 Nov 2024 13:20:58 -0800 Subject: [PATCH 05/14] try { defaultCommandTimeout: 60000 } --- .../integration_policy.cy.ts | 4 ++-- .../transaction_details.cy.ts | 23 ++++++++----------- 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts index 07a6b5740112a..b019b639c6473 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts @@ -28,7 +28,7 @@ const policyFormFields = [ }, ]; -describe.skip('when navigating to integration page', () => { +describe('when navigating to integration page', { defaultCommandTimeout: 60000 }, () => { beforeEach(() => { const integrationsPath = '/app/integrations/browse'; @@ -37,7 +37,7 @@ describe.skip('when navigating to integration page', () => { // open integration policy form cy.getByTestSubj('integration-card:ui_link:apm').click(); - cy.contains('Elastic APM in Fleet', { timeout: 60000 }).click(); + cy.contains('Elastic APM in Fleet').click(); cy.contains('a', 'APM integration').click(); cy.getByTestSubj('addIntegrationPolicyButton').click(); }); diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts index bfec80ad3296f..f81aa0787caeb 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts @@ -34,7 +34,7 @@ describe('Transaction details', () => { cy.loginAsViewerUser(); }); - it('shows transaction name and transaction charts', () => { + it('shows transaction name and transaction charts', { defaultCommandTimeout: 60000 }, () => { cy.intercept('GET', '/internal/apm/services/opbeans-java/transactions/charts/latency?*').as( 'transactionLatencyRequest' ); @@ -54,14 +54,11 @@ describe('Transaction details', () => { })}` ); - cy.wait( - [ - '@transactionLatencyRequest', - '@transactionThroughputRequest', - '@transactionFailureRateRequest', - ], - { timeout: 30000 } - ).spread((latencyInterception, throughputInterception, failureRateInterception) => { + cy.wait([ + '@transactionLatencyRequest', + '@transactionThroughputRequest', + '@transactionFailureRateRequest', + ]).spread((latencyInterception, throughputInterception, failureRateInterception) => { expect(latencyInterception.request.query.transactionName).to.be.eql('GET /api/product'); expect( @@ -106,7 +103,7 @@ describe('Transaction details', () => { ); cy.contains('Create SLO'); }); - it('shows top errors table', () => { + it('shows top errors table', { defaultCommandTimeout: 60000 }, () => { cy.visitKibana( `/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({ ...timeRange, @@ -114,10 +111,8 @@ describe('Transaction details', () => { })}` ); - cy.contains('Top 5 errors', { timeout: 60000 }); - cy.getByTestSubj('topErrorsForTransactionTable') - .contains('a', '[MockError] Foo', { timeout: 60000 }) - .click(); + cy.contains('Top 5 errors'); + cy.getByTestSubj('topErrorsForTransactionTable').contains('a', '[MockError] Foo').click(); cy.url().should('include', 'opbeans-java/errors'); }); From 9fe6c190cc4a1c924c67a222ab0c2e93f333a575 Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Fri, 8 Nov 2024 15:06:58 -0800 Subject: [PATCH 06/14] revert integration_policy --- .../cypress/e2e/integration_settings/integration_policy.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts index b019b639c6473..753e6476be1ed 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/integration_settings/integration_policy.cy.ts @@ -28,7 +28,7 @@ const policyFormFields = [ }, ]; -describe('when navigating to integration page', { defaultCommandTimeout: 60000 }, () => { +describe.skip('when navigating to integration page', () => { beforeEach(() => { const integrationsPath = '/app/integrations/browse'; From 451c362b19bd5cf4efd15219d074cd29956f6994 Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Mon, 11 Nov 2024 08:02:29 -0800 Subject: [PATCH 07/14] Fixed topErrorsForTransactionTable in transaction_details.cy.ts --- .../e2e/transaction_details/transaction_details.cy.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts index f81aa0787caeb..f467e3c28e95c 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts @@ -112,7 +112,10 @@ describe('Transaction details', () => { ); cy.contains('Top 5 errors'); - cy.getByTestSubj('topErrorsForTransactionTable').contains('a', '[MockError] Foo').click(); + cy.getByTestSubj('topErrorsForTransactionTable') + .should('be.visible') + .contains('a', '[MockError] Foo', { timeout: 10000 }) + .click(); cy.url().should('include', 'opbeans-java/errors'); }); From 78760296767b1833b94f5d2931ea96ce3a5b2898 Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Mon, 11 Nov 2024 11:19:45 -0800 Subject: [PATCH 08/14] increased timeout and removed selector specification for '[MockError] foo' --- .../transaction_details/transaction_details.cy.ts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts index f467e3c28e95c..367c80f2b10db 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts @@ -54,11 +54,14 @@ describe('Transaction details', () => { })}` ); - cy.wait([ - '@transactionLatencyRequest', - '@transactionThroughputRequest', - '@transactionFailureRateRequest', - ]).spread((latencyInterception, throughputInterception, failureRateInterception) => { + cy.wait( + [ + '@transactionLatencyRequest', + '@transactionThroughputRequest', + '@transactionFailureRateRequest', + ], + { timeout: 30000 } + ).spread((latencyInterception, throughputInterception, failureRateInterception) => { expect(latencyInterception.request.query.transactionName).to.be.eql('GET /api/product'); expect( @@ -114,7 +117,7 @@ describe('Transaction details', () => { cy.contains('Top 5 errors'); cy.getByTestSubj('topErrorsForTransactionTable') .should('be.visible') - .contains('a', '[MockError] Foo', { timeout: 10000 }) + .contains('[MockError] Foo', { timeout: 60000 }) .click(); cy.url().should('include', 'opbeans-java/errors'); }); From 651958c75bfa9634668004f2e3fe74a9c5d3a1e4 Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Tue, 19 Nov 2024 14:07:48 -0800 Subject: [PATCH 09/14] trying more specific data-test-subj & stop using getByTestSubj helper, to add timeout --- .../e2e/transaction_details/transaction_details.cy.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts index 367c80f2b10db..921c5cf2451f3 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts @@ -60,7 +60,7 @@ describe('Transaction details', () => { '@transactionThroughputRequest', '@transactionFailureRateRequest', ], - { timeout: 30000 } + { timeout: 60000 } ).spread((latencyInterception, throughputInterception, failureRateInterception) => { expect(latencyInterception.request.query.transactionName).to.be.eql('GET /api/product'); @@ -115,8 +115,8 @@ describe('Transaction details', () => { ); cy.contains('Top 5 errors'); - cy.getByTestSubj('topErrorsForTransactionTable') - .should('be.visible') + cy.get('[data-test-subj=topErrorsForTransactionTable]') + .get('[data-test-subj=apmLegacyAPMLinkLink]') .contains('[MockError] Foo', { timeout: 60000 }) .click(); cy.url().should('include', 'opbeans-java/errors'); From 2d9f12ea4c683852ea0a88b3d4001b8ed77caaec Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Tue, 19 Nov 2024 15:48:01 -0800 Subject: [PATCH 10/14] isolated transaction details top5 test into it's own test. --- .../transaction_details.cy.ts | 15 ------ .../transaction_details_top5.cy.ts | 51 +++++++++++++++++++ 2 files changed, 51 insertions(+), 15 deletions(-) create mode 100644 x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts index 921c5cf2451f3..cb12026b8cfc8 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts @@ -106,21 +106,6 @@ describe('Transaction details', () => { ); cy.contains('Create SLO'); }); - it('shows top errors table', { defaultCommandTimeout: 60000 }, () => { - cy.visitKibana( - `/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({ - ...timeRange, - transactionName: 'GET /api/product', - })}` - ); - - cy.contains('Top 5 errors'); - cy.get('[data-test-subj=topErrorsForTransactionTable]') - .get('[data-test-subj=apmLegacyAPMLinkLink]') - .contains('[MockError] Foo', { timeout: 60000 }) - .click(); - cy.url().should('include', 'opbeans-java/errors'); - }); describe('when navigating to a trace sample', () => { it('keeps the same trace sample after reloading the page', () => { diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts new file mode 100644 index 0000000000000..48dcd5858f656 --- /dev/null +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts @@ -0,0 +1,51 @@ +/* + * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one + * or more contributor license agreements. Licensed under the Elastic License + * 2.0; you may not use this file except in compliance with the Elastic License + * 2.0. + */ +import { synthtrace } from '../../../synthtrace'; +import { opbeans } from '../../fixtures/synthtrace/opbeans'; + +const start = '2021-10-10T00:00:00.000Z'; +const end = '2021-10-10T00:15:00.000Z'; + +const timeRange = { + rangeFrom: start, + rangeTo: end, +}; +// flaky +describe('Transaction details', () => { + before(() => { + synthtrace.index( + opbeans({ + from: new Date(start).getTime(), + to: new Date(end).getTime(), + }) + ); + }); + + after(() => { + synthtrace.clean(); + }); + + beforeEach(() => { + cy.loginAsViewerUser(); + }); + + it('shows top errors table', { defaultCommandTimeout: 60000 }, () => { + cy.visitKibana( + `/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({ + ...timeRange, + transactionName: 'GET /api/product', + })}` + ); + + cy.contains('Top 5 errors'); + cy.get('[data-test-subj=topErrorsForTransactionTable]', { timeout: 60000 }) + .get('[data-test-subj=apmLegacyAPMLinkLink]', { timeout: 60000 }) + .contains('[MockError] Foo', { timeout: 60000 }) + .click(); + cy.url().should('include', 'opbeans-java/errors'); + }); +}); From 42198545820b85b0e8d84029a844e454dccb96c3 Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Wed, 20 Nov 2024 07:13:08 -0800 Subject: [PATCH 11/14] changed describe name slightly for top5 tests --- .../e2e/transaction_details/transaction_details_top5.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts index 48dcd5858f656..4bd691578d50e 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts @@ -15,7 +15,7 @@ const timeRange = { rangeTo: end, }; // flaky -describe('Transaction details', () => { +describe('Transaction details errors table', () => { before(() => { synthtrace.index( opbeans({ From b91a32a828f9c11eaec5f12d5394fd16c67d7a6e Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Wed, 20 Nov 2024 08:44:34 -0800 Subject: [PATCH 12/14] added wait time before loading the page to ensure test data is in the index --- .../e2e/transaction_details/transaction_details_top5.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts index 4bd691578d50e..a2d288b651321 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts @@ -34,6 +34,7 @@ describe('Transaction details errors table', () => { }); it('shows top errors table', { defaultCommandTimeout: 60000 }, () => { + cy.wait(60000); cy.visitKibana( `/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({ ...timeRange, @@ -43,7 +44,6 @@ describe('Transaction details errors table', () => { cy.contains('Top 5 errors'); cy.get('[data-test-subj=topErrorsForTransactionTable]', { timeout: 60000 }) - .get('[data-test-subj=apmLegacyAPMLinkLink]', { timeout: 60000 }) .contains('[MockError] Foo', { timeout: 60000 }) .click(); cy.url().should('include', 'opbeans-java/errors'); From e2115b05793fc1e277d8de11bd89d106c9959758 Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Wed, 20 Nov 2024 10:16:38 -0800 Subject: [PATCH 13/14] simplifying test --- .../e2e/transaction_details/transaction_details_top5.cy.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts index a2d288b651321..88b89accca48b 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts @@ -42,10 +42,7 @@ describe('Transaction details errors table', () => { })}` ); - cy.contains('Top 5 errors'); - cy.get('[data-test-subj=topErrorsForTransactionTable]', { timeout: 60000 }) - .contains('[MockError] Foo', { timeout: 60000 }) - .click(); + cy.contains('[MockError] Foo', { timeout: 60000 }).click(); cy.url().should('include', 'opbeans-java/errors'); }); }); From 01d0833255b3a351405c1206cbdfabc66a9a471e Mon Sep 17 00:00:00 2001 From: Bryce Buchanan Date: Mon, 2 Dec 2024 11:52:41 -0800 Subject: [PATCH 14/14] marked 'shows top errors table' as flaky and skipped --- .../transaction_details.cy.ts | 15 +++++- .../transaction_details_top5.cy.ts | 48 ------------------- 2 files changed, 14 insertions(+), 49 deletions(-) delete mode 100644 x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts index cb12026b8cfc8..bd24294f28ca2 100644 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts +++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts @@ -15,7 +15,6 @@ const timeRange = { rangeFrom: start, rangeTo: end, }; -// flaky describe('Transaction details', () => { before(() => { synthtrace.index( @@ -107,6 +106,20 @@ describe('Transaction details', () => { cy.contains('Create SLO'); }); + // flaky + it.skip('shows top errors table', () => { + cy.visitKibana( + `/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({ + ...timeRange, + transactionName: 'GET /api/product', + })}` + ); + + cy.contains('Top 5 errors', { timeout: 30000 }); + cy.getByTestSubj('topErrorsForTransactionTable').contains('a', '[MockError] Foo').click(); + cy.url().should('include', 'opbeans-java/errors'); + }); + describe('when navigating to a trace sample', () => { it('keeps the same trace sample after reloading the page', () => { cy.visitKibana( diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts deleted file mode 100644 index 88b89accca48b..0000000000000 --- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details_top5.cy.ts +++ /dev/null @@ -1,48 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the Elastic License - * 2.0; you may not use this file except in compliance with the Elastic License - * 2.0. - */ -import { synthtrace } from '../../../synthtrace'; -import { opbeans } from '../../fixtures/synthtrace/opbeans'; - -const start = '2021-10-10T00:00:00.000Z'; -const end = '2021-10-10T00:15:00.000Z'; - -const timeRange = { - rangeFrom: start, - rangeTo: end, -}; -// flaky -describe('Transaction details errors table', () => { - before(() => { - synthtrace.index( - opbeans({ - from: new Date(start).getTime(), - to: new Date(end).getTime(), - }) - ); - }); - - after(() => { - synthtrace.clean(); - }); - - beforeEach(() => { - cy.loginAsViewerUser(); - }); - - it('shows top errors table', { defaultCommandTimeout: 60000 }, () => { - cy.wait(60000); - cy.visitKibana( - `/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({ - ...timeRange, - transactionName: 'GET /api/product', - })}` - ); - - cy.contains('[MockError] Foo', { timeout: 60000 }).click(); - cy.url().should('include', 'opbeans-java/errors'); - }); -});