From 18a9098949927b4abad3cdf1bee015680f7ddf8a Mon Sep 17 00:00:00 2001 From: Tim Sullivan Date: Tue, 5 Nov 2024 13:08:05 -0700 Subject: [PATCH] [unified_doc_viewer / unified_search] clean up SASS compilation warnings (#198876) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary This PR cleans up two noisy warnings seen when building Kibana: ``` [2024-11-04 21:26:37] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. [2024-11-04 21:26:37] │ warn worker stderr [2024-11-04 21:26:37] │ warn worker stderr Recommendation: math.div($euiSizeXS, 2) or calc($euiSizeXS / 2) [2024-11-04 21:26:37] │ warn worker stderr [2024-11-04 21:26:37] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div [2024-11-04 21:26:37] │ warn worker stderr [2024-11-04 21:26:37] │ warn worker stderr ╷ [2024-11-04 21:26:37] │ warn worker stderr 94 │ padding: $euiSizeXS / 2 0 0 $euiSizeXS; [2024-11-04 21:26:37] │ warn worker stderr │ ^^^^^^^^^^^^^^ [2024-11-04 21:26:37] │ warn worker stderr ╵ [2024-11-04 21:26:37] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss 94:14 root stylesheet [2024-11-04 21:26:37] │ warn worker stderr [2024-11-04 21:35:27] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. [2024-11-04 21:35:27] │ warn worker stderr [2024-11-04 21:35:27] │ warn worker stderr Recommendation: math.div($euiSizeM, 2) or calc($euiSizeM / 2) [2024-11-04 21:35:27] │ warn worker stderr [2024-11-04 21:35:27] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div [2024-11-04 21:35:27] │ warn worker stderr [2024-11-04 21:35:27] │ warn worker stderr ╷ [2024-11-04 21:35:27] │ warn worker stderr 11 │ padding-block: $euiSizeM / 2; [2024-11-04 21:35:27] │ warn worker stderr │ ^^^^^^^^^^^^^ [2024-11-04 21:35:27] │ warn worker stderr ╵ [2024-11-04 21:35:27] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss 11:18 root stylesheet ``` (cherry picked from commit 7a3a2b3cb8525acca46481508663d6fd98c5b27b) --- .../public/components/doc_viewer_table/table.scss | 2 +- .../public/filter_bar/filter_item/filter_item.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss index 19d556b0b142a..64e700c73fca5 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss @@ -90,7 +90,7 @@ } & [data-gridcell-column-id='pin_field'] .euiDataGridRowCell__content { - padding: $euiSizeXS / 2 0 0 $euiSizeXS; + padding: calc($euiSizeXS / 2) 0 0 $euiSizeXS; } .kbnDocViewer__fieldsGrid__pinAction { diff --git a/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss b/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss index 7a14dd3a64ef3..85c5b6bb9278f 100644 --- a/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss +++ b/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss @@ -7,7 +7,7 @@ .globalFilterItem { line-height: $euiSize; color: $euiTextColor; - padding-block: $euiSizeM / 2; + padding-block: calc($euiSizeM / 2); white-space: normal; /* 1 */ &:not(.globalFilterItem-isDisabled) {