Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security solution] assistantKnowledgeBaseByDefault flag defaults to true #198178

Merged
merged 5 commits into from
Oct 31, 2024
Merged

[Security solution] assistantKnowledgeBaseByDefault flag defaults to true #198178

merged 5 commits into from
Oct 31, 2024
+3 −82

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 29, 2024 •
edited
Loading

Summary

Updates the assistantKnowledgeBaseByDefault flag defaults to true, enabling the flag by default with no ability to turn it off besides reverting this PR.

This PR will be backported to 8.16, 8.x and main, but it is intended to live in 8.16 only . This PR will be followed up by a PR to remove the feature flag and all of its code paths, but that PR will only be backported to8.x and main in order to not risk many code changes in 8.16.

PR merge order

  1. [Security solution] Knowledge base tour video update merged!
  2. [Security Assistant] Knowledge base switch to use semantic_text) merged!
  3. [Security AI Assistant] Fixed license issue for Knowledge Base resources initialization merged!
  4. [Security solution] assistantKnowledgeBaseByDefault flag defaults to true (THIS PR)
  5. [Security solution] assistantKnowledgeBaseByDefault flag removed

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 29, 2024
@stephmilovic stephmilovic requested review from a team as code owners October 29, 2024 17:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

This was referenced Oct 29, 2024
Merged
Merged
@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from elasticmachine Oct 30, 2024
@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

andrew-goldstein
andrew-goldstein approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephmilovic!
✅ Desk tested locally
LGTM 🚀

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@stephmilovic stephmilovic merged commit 88225ff into elastic:main Oct 31, 2024
43 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11605122253

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 31, 2024
@stephmilovic
[Security solution] assistantKnowledgeBaseByDefault flag defaults t…
4a42438 
…o `true` (elastic#198178)

(cherry picked from commit 88225ff)
@kibanamachine kibanamachine mentioned this pull request Oct 31, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 31, 2024
@stephmilovic
[Security solution] assistantKnowledgeBaseByDefault flag defaults t…
e42b044 
…o `true` (elastic#198178)

(cherry picked from commit 88225ff)
@kibanamachine kibanamachine mentioned this pull request Oct 31, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 31, 2024
@kibanamachine @stephmilovic
[8.16] [Security solution] `assistantKnowledgeBaseByDefault&#x60…
6014038 
…; flag defaults to `true` (#198178) (#198458)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security solution] `assistantKnowledgeBaseByDefault` flag
defaults to `true`
(#198178)](#198178)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T02:36:14Z","message":"[Security
solution] `assistantKnowledgeBaseByDefault` flag defaults to `true`
(#198178)","sha":"88225fff07c416a6939c415d8ac65e473a3ffd0e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Team:Security Generative
AI","v8.16.0","backport:version","v8.17.0"],"title":"[Security solution]
`assistantKnowledgeBaseByDefault` flag defaults to
`true`","number":198178,"url":"https://github.com/elastic/kibana/pull/198178","mergeCommit":{"message":"[Security
solution] `assistantKnowledgeBaseByDefault` flag defaults to `true`
(#198178)","sha":"88225fff07c416a6939c415d8ac65e473a3ffd0e"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198178","number":198178,"mergeCommit":{"message":"[Security
solution] `assistantKnowledgeBaseByDefault` flag defaults to `true`
(#198178)","sha":"88225fff07c416a6939c415d8ac65e473a3ffd0e"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 31, 2024
@kibanamachine @stephmilovic @patrykkopycinski
[8.x] [Security solution] &#x60;assistantKnowledgeBaseByDefault&#x60;…
fe3a0ff 
… flag defaults to &#x60;true&#x60; (#198178) (#198459)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security solution] &#x60;assistantKnowledgeBaseByDefault&#x60; flag
defaults to &#x60;true&#x60;
(#198178)](#198178)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T02:36:14Z","message":"[Security
solution] `assistantKnowledgeBaseByDefault` flag defaults to `true`
(#198178)","sha":"88225fff07c416a6939c415d8ac65e473a3ffd0e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Team:Security Generative
AI","v8.16.0","backport:version","v8.17.0"],"title":"[Security solution]
`assistantKnowledgeBaseByDefault` flag defaults to
`true`","number":198178,"url":"https://github.com/elastic/kibana/pull/198178","mergeCommit":{"message":"[Security
solution] `assistantKnowledgeBaseByDefault` flag defaults to `true`
(#198178)","sha":"88225fff07c416a6939c415d8ac65e473a3ffd0e"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198178","number":198178,"mergeCommit":{"message":"[Security
solution] `assistantKnowledgeBaseByDefault` flag defaults to `true`
(#198178)","sha":"88225fff07c416a6939c415d8ac65e473a3ffd0e"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
Co-authored-by: Patryk Kopyciński <[email protected]>
This was referenced Oct 31, 2024
Closed
Merged
e40pud added a commit that referenced this pull request Nov 5, 2024
@e40pud
[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (#1…
69c1e5a 
…98861)

## Summary

This is a followup to #198178
where we skipped KB integration tests. We enable it with this PR.

Since it takes a lot of time to setup all Security Labs docs, the idea
is to skip installing those docs when it is not needed. For these tests
we need to make sure that inference endpoint is setup correctly - labs
docs are not required in this case.

cc @stephmilovic
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2024
@e40pud
[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (el…
a3f94f2 
…astic#198861)

## Summary

This is a followup to elastic#198178
where we skipped KB integration tests. We enable it with this PR.

Since it takes a lot of time to setup all Security Labs docs, the idea
is to skip installing those docs when it is not needed. For these tests
we need to make sure that inference endpoint is setup correctly - labs
docs are not required in this case.

cc @stephmilovic

(cherry picked from commit 69c1e5a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2024
@e40pud
[Security GenAI] Fix and un-skip Knowledge Base Integration Tests (el…
55c2f2a 
…astic#198861)

## Summary

This is a followup to elastic#198178
where we skipped KB integration tests. We enable it with this PR.

Since it takes a lot of time to setup all Security Labs docs, the idea
is to skip installing those docs when it is not needed. For these tests
we need to make sure that inference endpoint is setup correctly - labs
docs are not required in this case.

cc @stephmilovic

(cherry picked from commit 69c1e5a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephmilovic @elasticmachine @kibanamachine @andrew-goldstein @patrykkopycinski