From 1f48fc8b9e9b6cfe02a62e6c771cf9224eff66bb Mon Sep 17 00:00:00 2001 From: Mohamed Nabeel <137497525+nabeelmohamed@users.noreply.github.com> Date: Sat, 19 Oct 2024 10:08:37 +0530 Subject: [PATCH 1/5] Fix typo: change 'dashaboard' to 'dashboard' on APM-service Dashboards page --- .../components/app/service_dashboards/empty_dashboards.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/apm/public/components/app/service_dashboards/empty_dashboards.tsx b/x-pack/plugins/observability_solution/apm/public/components/app/service_dashboards/empty_dashboards.tsx index 9ce282d267f11..9b7ace008206b 100644 --- a/x-pack/plugins/observability_solution/apm/public/components/app/service_dashboards/empty_dashboards.tsx +++ b/x-pack/plugins/observability_solution/apm/public/components/app/service_dashboards/empty_dashboards.tsx @@ -59,7 +59,7 @@ export function EmptyDashboards({ actions }: Props) {

{i18n.translate('xpack.apm.serviceDashboards.emptyBody.getStarted', { - defaultMessage: 'To get started, add your dashaboard', + defaultMessage: 'To get started, add your dashboard', })}

From a613d78713c72760c5df038471397409dcc54da6 Mon Sep 17 00:00:00 2001 From: Mohamed Nabeel <137497525+nabeelmohamed@users.noreply.github.com> Date: Fri, 25 Oct 2024 10:15:53 +0530 Subject: [PATCH 2/5] Update index.ts --- src/core/public/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/public/index.ts b/src/core/public/index.ts index ecce03d0b5092..356f87d54f089 100644 --- a/src/core/public/index.ts +++ b/src/core/public/index.ts @@ -170,7 +170,6 @@ export type { export { CoreScopedHistory } from '@kbn/core-application-browser-internal'; export type { - SavedObjectsClientContract, SimpleSavedObject, SavedObjectsCreateOptions, SavedObjectsDeleteOptions, From 7ce6a0c8e73996dbcf610994521cbe0e52fc5fa8 Mon Sep 17 00:00:00 2001 From: Mohamed Nabeel <137497525+nabeelmohamed@users.noreply.github.com> Date: Fri, 25 Oct 2024 10:19:25 +0530 Subject: [PATCH 3/5] Update index.ts in path kibana/src/plugins/saved_objects/public/saved_object/ by removing unused objects like saveWithConfirmation and checkForDuplicateTitle. --- src/plugins/saved_objects/public/saved_object/index.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/plugins/saved_objects/public/saved_object/index.ts b/src/plugins/saved_objects/public/saved_object/index.ts index 560178fdf4f36..68639d030317e 100644 --- a/src/plugins/saved_objects/public/saved_object/index.ts +++ b/src/plugins/saved_objects/public/saved_object/index.ts @@ -7,6 +7,4 @@ * License v3.0 only", or the "Server Side Public License, v 1". */ -export { checkForDuplicateTitle } from './helpers/check_for_duplicate_title'; -export { saveWithConfirmation } from './helpers/save_with_confirmation'; export { isErrorNonFatal } from './helpers/save_saved_object'; From 750c9bd0aad2143fd4460bfdef2bcba06eb7cae8 Mon Sep 17 00:00:00 2001 From: Mohamed Nabeel <137497525+nabeelmohamed@users.noreply.github.com> Date: Fri, 25 Oct 2024 16:55:27 +0530 Subject: [PATCH 4/5] fix: Re-add removed lines in index.ts --- src/plugins/saved_objects/public/saved_object/index.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/saved_objects/public/saved_object/index.ts b/src/plugins/saved_objects/public/saved_object/index.ts index 68639d030317e..560178fdf4f36 100644 --- a/src/plugins/saved_objects/public/saved_object/index.ts +++ b/src/plugins/saved_objects/public/saved_object/index.ts @@ -7,4 +7,6 @@ * License v3.0 only", or the "Server Side Public License, v 1". */ +export { checkForDuplicateTitle } from './helpers/check_for_duplicate_title'; +export { saveWithConfirmation } from './helpers/save_with_confirmation'; export { isErrorNonFatal } from './helpers/save_saved_object'; From e6d6a0cbf08d9dd8c19645c94507c5117117ab1c Mon Sep 17 00:00:00 2001 From: Mohamed Nabeel <137497525+nabeelmohamed@users.noreply.github.com> Date: Mon, 28 Oct 2024 10:02:46 +0530 Subject: [PATCH 5/5] re added SavedObjectsclient contract at src/core/public/index.ts --- src/core/public/index.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/public/index.ts b/src/core/public/index.ts index 356f87d54f089..ecce03d0b5092 100644 --- a/src/core/public/index.ts +++ b/src/core/public/index.ts @@ -170,6 +170,7 @@ export type { export { CoreScopedHistory } from '@kbn/core-application-browser-internal'; export type { + SavedObjectsClientContract, SimpleSavedObject, SavedObjectsCreateOptions, SavedObjectsDeleteOptions,