From 35e188622043cd851ffa2036f7b04ec3ce64ee70 Mon Sep 17 00:00:00 2001 From: Ignacio Rivas Date: Fri, 20 Sep 2024 08:47:26 +0200 Subject: [PATCH 1/4] No need to include FF in the test suite --- test/functional/apps/console/_onboarding_tour.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/test/functional/apps/console/_onboarding_tour.ts b/test/functional/apps/console/_onboarding_tour.ts index 174c892281c0f..330498cb7b5ec 100644 --- a/test/functional/apps/console/_onboarding_tour.ts +++ b/test/functional/apps/console/_onboarding_tour.ts @@ -17,7 +17,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const testSubjects = getService('testSubjects'); describe('console onboarding tour', function describeIndexTests() { - this.tags('includeFirefox'); before(async () => { log.debug('navigateTo console'); await PageObjects.common.navigateToApp('console'); From 5308a58b45263229164033ced2a3e8c70ce0b624 Mon Sep 17 00:00:00 2001 From: Ignacio Rivas Date: Fri, 20 Sep 2024 08:47:32 +0200 Subject: [PATCH 2/4] commit with @elastic email From 4b7609f4ea92993c2b56bf2987b946573a84a11e Mon Sep 17 00:00:00 2001 From: Ignacio Rivas Date: Fri, 20 Sep 2024 08:55:18 +0200 Subject: [PATCH 3/4] Also dont run tests in FF for this suite --- test/functional/apps/console/_console.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/test/functional/apps/console/_console.ts b/test/functional/apps/console/_console.ts index 6b6b192373ea6..64d71ddbfc82d 100644 --- a/test/functional/apps/console/_console.ts +++ b/test/functional/apps/console/_console.ts @@ -20,7 +20,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const security = getService('security'); describe('console app', function describeIndexTests() { - this.tags('includeFirefox'); before(async () => { log.debug('navigateTo console'); await PageObjects.common.navigateToApp('console'); From 707aee68873f63f00332a87b689b342f1735463d Mon Sep 17 00:00:00 2001 From: Ignacio Rivas Date: Fri, 20 Sep 2024 09:03:02 +0200 Subject: [PATCH 4/4] Unskip and remove from running on FF --- test/functional/apps/console/_autocomplete.ts | 4 +--- test/functional/apps/console/_misc_console_behavior.ts | 4 +--- test/functional/apps/console/_variables.ts | 5 +---- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/test/functional/apps/console/_autocomplete.ts b/test/functional/apps/console/_autocomplete.ts index 64db13fa67ec2..99e97d979d281 100644 --- a/test/functional/apps/console/_autocomplete.ts +++ b/test/functional/apps/console/_autocomplete.ts @@ -34,9 +34,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); } - // Failing: See https://github.com/elastic/kibana/issues/191808 - describe.skip('console autocomplete feature', function describeIndexTests() { - this.tags('includeFirefox'); + describe('console autocomplete feature', function describeIndexTests() { before(async () => { log.debug('navigateTo console'); await PageObjects.common.navigateToApp('console'); diff --git a/test/functional/apps/console/_misc_console_behavior.ts b/test/functional/apps/console/_misc_console_behavior.ts index 05cd34d1c2a7f..4185a2198fa32 100644 --- a/test/functional/apps/console/_misc_console_behavior.ts +++ b/test/functional/apps/console/_misc_console_behavior.ts @@ -18,9 +18,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const browser = getService('browser'); const PageObjects = getPageObjects(['common', 'console', 'header']); - // Failing: See https://github.com/elastic/kibana/issues/193309 - describe.skip('misc console behavior', function testMiscConsoleBehavior() { - this.tags('includeFirefox'); + describe('misc console behavior', function testMiscConsoleBehavior() { before(async () => { await browser.setWindowSize(1200, 800); await PageObjects.common.navigateToApp('console'); diff --git a/test/functional/apps/console/_variables.ts b/test/functional/apps/console/_variables.ts index a5eef8cccd15d..999d8354a1d9c 100644 --- a/test/functional/apps/console/_variables.ts +++ b/test/functional/apps/console/_variables.ts @@ -15,10 +15,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => { const log = getService('log'); const PageObjects = getPageObjects(['common', 'console', 'header']); - // Failing: See https://github.com/elastic/kibana/issues/157776 - describe.skip('Console variables', function testConsoleVariables() { - this.tags('includeFirefox'); - + describe('Console variables', function testConsoleVariables() { before(async () => { log.debug('navigateTo console'); await PageObjects.common.navigateToApp('console');