Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fix and skip flaky tests #193508

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Sep 20, 2024

Summary

This PR aims to fix a few problems we started having recently in few integration tests as we merged the console ux improvements.

@sabarasaba sabarasaba self-assigned this Sep 20, 2024
@sabarasaba sabarasaba added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Sep 20, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6988

[✅] test/functional/apps/console/config.ts: 200/200 tests passed.

see run history

@sabarasaba sabarasaba marked this pull request as ready for review September 20, 2024 09:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 193508

Questions ?

Please refer to the Backport tool documentation

@sabarasaba
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Sep 20, 2024
(cherry picked from commit 5ea37fb)

# Conflicts:
#	test/functional/apps/console/_autocomplete.ts
#	test/functional/apps/console/_misc_console_behavior.ts
#	test/functional/apps/console/_variables.ts
sabarasaba added a commit that referenced this pull request Sep 20, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Console] Fix and skip flaky tests
(#193508)](#193508)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T09:45:55Z","message":"[Console]
Fix and skip flaky tests
(#193508)","sha":"5ea37fb47063645e5cf97ce66f210e8c3d4ee51f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"number":193508,"url":"https://github.com/elastic/kibana/pull/193508","mergeCommit":{"message":"[Console]
Fix and skip flaky tests
(#193508)","sha":"5ea37fb47063645e5cf97ce66f210e8c3d4ee51f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193508","number":193508,"mergeCommit":{"message":"[Console]
Fix and skip flaky tests
(#193508)","sha":"5ea37fb47063645e5cf97ce66f210e8c3d4ee51f"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants