[Unified Search] Remove soon-to-be-deprecated EuiFormControl Sass mixins #193472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in an ideal world, we'd use the new Emotion `--euiFormControlRight/LeftIconsCount` CSS variables, but EuiTextArea traditionally has absolutely positioned icons which it doesn't afford for in padding - as this is a very custom implementation of EuiTextArea, setting the padding manually is fine
cee-chen
added
release_note:skip
1 task
|
Pinging @elastic/eui-team (EUI) |
ryankeairns
approved these changes
Sep 20, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 24, 2024
…ins (elastic#193472) ## Summary As part of our ongoing transition towards CSS-in-JS, EUI is cleaning up and removing several publicly exported Sass mixins and variables with very low usage (0-1 usages across Kibana and Cloud) (full list in elastic/eui#8031). This PR identifies and replaces one of them (`@euiFormControlWithIcon`) with their functional padding output equivalents (still using generic EUI Sass variables - there are no plans to immediately deprecate those). There should be **no UI regressions** in the unified search query bar compared to main, the right and left padding should remain the same: <img width="925" alt="" src="https://github.com/user-attachments/assets/ac6359af-5169-4642-ba7e-64e42cb57749"> ### Checklist Delete any items that are not applicable to this PR. - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit b3d28c8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
…ss mixins (#193472) (#193806) # Backport This will backport the following commits from `main` to `8.x`: - [[Unified Search] Remove soon-to-be-deprecated EuiFormControl Sass mixins (#193472)](#193472) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-24T00:04:45Z","message":"[Unified Search] Remove soon-to-be-deprecated EuiFormControl Sass mixins (#193472)\n\n## Summary\r\n\r\nAs part of our ongoing transition towards CSS-in-JS, EUI is cleaning up\r\nand removing several publicly exported Sass mixins and variables with\r\nvery low usage (0-1 usages across Kibana and Cloud) (full list in\r\nhttps://github.com/elastic/eui/pull/8031).\r\n\r\nThis PR identifies and replaces one of them (`@euiFormControlWithIcon`)\r\nwith their functional padding output equivalents (still using generic\r\nEUI Sass variables - there are no plans to immediately deprecate those).\r\n\r\nThere should be **no UI regressions** in the unified search query bar\r\ncompared to main, the right and left padding should remain the same:\r\n\r\n<img width=\"925\" alt=\"\"\r\nsrc=\"https://github.com/user-attachments/assets/ac6359af-5169-4642-ba7e-64e42cb57749\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"b3d28c8290891b42175c335ea22c550392bbca9c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","v8.16.0","backport:version"],"title":"[Unified Search] Remove soon-to-be-deprecated EuiFormControl Sass mixins","number":193472,"url":"https://github.com/elastic/kibana/pull/193472","mergeCommit":{"message":"[Unified Search] Remove soon-to-be-deprecated EuiFormControl Sass mixins (#193472)\n\n## Summary\r\n\r\nAs part of our ongoing transition towards CSS-in-JS, EUI is cleaning up\r\nand removing several publicly exported Sass mixins and variables with\r\nvery low usage (0-1 usages across Kibana and Cloud) (full list in\r\nhttps://github.com/elastic/eui/pull/8031).\r\n\r\nThis PR identifies and replaces one of them (`@euiFormControlWithIcon`)\r\nwith their functional padding output equivalents (still using generic\r\nEUI Sass variables - there are no plans to immediately deprecate those).\r\n\r\nThere should be **no UI regressions** in the unified search query bar\r\ncompared to main, the right and left padding should remain the same:\r\n\r\n<img width=\"925\" alt=\"\"\r\nsrc=\"https://github.com/user-attachments/assets/ac6359af-5169-4642-ba7e-64e42cb57749\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"b3d28c8290891b42175c335ea22c550392bbca9c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193472","number":193472,"mergeCommit":{"message":"[Unified Search] Remove soon-to-be-deprecated EuiFormControl Sass mixins (#193472)\n\n## Summary\r\n\r\nAs part of our ongoing transition towards CSS-in-JS, EUI is cleaning up\r\nand removing several publicly exported Sass mixins and variables with\r\nvery low usage (0-1 usages across Kibana and Cloud) (full list in\r\nhttps://github.com/elastic/eui/pull/8031).\r\n\r\nThis PR identifies and replaces one of them (`@euiFormControlWithIcon`)\r\nwith their functional padding output equivalents (still using generic\r\nEUI Sass variables - there are no plans to immediately deprecate those).\r\n\r\nThere should be **no UI regressions** in the unified search query bar\r\ncompared to main, the right and left padding should remain the same:\r\n\r\n<img width=\"925\" alt=\"\"\r\nsrc=\"https://github.com/user-attachments/assets/ac6359af-5169-4642-ba7e-64e42cb57749\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"b3d28c8290891b42175c335ea22c550392bbca9c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cee Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of our ongoing transition towards CSS-in-JS, EUI is cleaning up and removing several publicly exported Sass mixins and variables with very low usage (0-1 usages across Kibana and Cloud) (full list in elastic/eui#8031).
This PR identifies and replaces one of them (
@euiFormControlWithIcon) with their functional padding output equivalents (still using generic EUI Sass variables - there are no plans to immediately deprecate those).There should be no UI regressions in the unified search query bar compared to main, the right and left padding should remain the same:
Checklist
Delete any items that are not applicable to this PR.