[Entity Analytics] [Entity Store] Add basic e2e tests and + tidy API route names #193161
+562
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
hop-dev
added
the
backport:prev-minor
machadoum
approved these changes
Sep 20, 2024
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @hop-dev |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 24, 2024
…route names (elastic#193161) ## Summary Adds basic end to end tests for the engine CRUD routes. I also noticed there was some inconsistency in the naming of the API routes which I have fixed. --------- Co-authored-by: machadoum <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Tiago Vila Verde <[email protected]> (cherry picked from commit 0b4f877)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
…y API route names (#193161) (#193829) # Backport This will backport the following commits from `main` to `8.x`: - [[Entity Analytics] [Entity Store] Add basic e2e tests and + tidy API route names (#193161)](#193161) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-24T08:31:32Z","message":"[Entity Analytics] [Entity Store] Add basic e2e tests and + tidy API route names (#193161)\n\n## Summary\r\n\r\nAdds basic end to end tests for the engine CRUD routes.\r\n\r\nI also noticed there was some inconsistency in the naming of the API\r\nroutes which I have fixed.\r\n\r\n---------\r\n\r\nCo-authored-by: machadoum <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Tiago Vila Verde <[email protected]>","sha":"0b4f8774dd933dbfb9cc7816b2484bf5cc25752e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","Feature:Entity Analytics","Team:Entity Analytics","v8.16.0"],"title":"[Entity Analytics] [Entity Store] Add basic e2e tests and + tidy API route names","number":193161,"url":"https://github.com/elastic/kibana/pull/193161","mergeCommit":{"message":"[Entity Analytics] [Entity Store] Add basic e2e tests and + tidy API route names (#193161)\n\n## Summary\r\n\r\nAdds basic end to end tests for the engine CRUD routes.\r\n\r\nI also noticed there was some inconsistency in the naming of the API\r\nroutes which I have fixed.\r\n\r\n---------\r\n\r\nCo-authored-by: machadoum <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Tiago Vila Verde <[email protected]>","sha":"0b4f8774dd933dbfb9cc7816b2484bf5cc25752e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193161","number":193161,"mergeCommit":{"message":"[Entity Analytics] [Entity Store] Add basic e2e tests and + tidy API route names (#193161)\n\n## Summary\r\n\r\nAdds basic end to end tests for the engine CRUD routes.\r\n\r\nI also noticed there was some inconsistency in the naming of the API\r\nroutes which I have fixed.\r\n\r\n---------\r\n\r\nCo-authored-by: machadoum <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Tiago Vila Verde <[email protected]>","sha":"0b4f8774dd933dbfb9cc7816b2484bf5cc25752e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mark Hopkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds basic end to end tests for the engine CRUD routes.
I also noticed there was some inconsistency in the naming of the API routes which I have fixed.