From 220c908637e8be97dd0c36e20885090631c25a53 Mon Sep 17 00:00:00 2001 From: Melissa Date: Fri, 6 Sep 2024 20:49:18 -0600 Subject: [PATCH 1/3] add esql data visualizer to security nav --- .../security-solution/navigation/src/constants.ts | 1 + .../solution_navigation/links/sections/ml_links.ts | 7 +++++++ .../links/sections/ml_translations.ts | 12 ++++++++++++ 3 files changed, 20 insertions(+) diff --git a/x-pack/packages/security-solution/navigation/src/constants.ts b/x-pack/packages/security-solution/navigation/src/constants.ts index e8d1888b08e5c..99ae27ff74f2c 100644 --- a/x-pack/packages/security-solution/navigation/src/constants.ts +++ b/x-pack/packages/security-solution/navigation/src/constants.ts @@ -53,6 +53,7 @@ export enum ExternalPageName { mlNodes = 'ml:nodes', mlFileUpload = 'ml:fileUpload', mlIndexDataVisualizer = 'ml:indexDataVisualizer', + mlESQLdataVisualizer = 'ml:esqlDataVisualizer', mlDataDrift = 'ml:dataDrift', mlExplainLogRateSpikes = 'ml:logRateAnalysis', mlLogPatternAnalysis = 'ml:logPatternAnalysis', diff --git a/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts b/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts index 76611868f4a3a..5e6c80a9060c0 100644 --- a/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts +++ b/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts @@ -86,6 +86,7 @@ export const mlNavCategories: SolutionLinkCategory[] = [ ExternalPageName.mlFileUpload, ExternalPageName.mlIndexDataVisualizer, ExternalPageName.mlDataDrift, + ExternalPageName.mlESQLdataVisualizer, ], }, { @@ -179,6 +180,12 @@ export const mlNavLinks: SolutionNavLink[] = [ landingIcon: IconDataViewLazy, description: i18n.INDEX_DATA_VISUALIZER_DESC, }, + { + id: ExternalPageName.mlESQLdataVisualizer, + title: i18n.ESQL_DATA_VISUALIZER_TITLE, + landingIcon: IconDataViewLazy, + description: i18n.ESQL_DATA_VISUALIZER_DESC, + }, { id: ExternalPageName.mlDataDrift, title: i18n.DATA_DRIFT_TITLE, diff --git a/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_translations.ts b/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_translations.ts index 5563ff8b8b5b5..b77e89a9b0b71 100644 --- a/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_translations.ts +++ b/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_translations.ts @@ -195,6 +195,18 @@ export const INDEX_DATA_VISUALIZER_DESC = i18n.translate( defaultMessage: 'Data view data visualizer page', } ); +export const ESQL_DATA_VISUALIZER_TITLE = i18n.translate( + 'xpack.securitySolution.navLinks.ml.esqlDataVisualizer.title', + { + defaultMessage: 'ES|QL data visualizer', + } +); +export const ESQL_DATA_VISUALIZER_DESC = i18n.translate( + 'xpack.securitySolution.navLinks.ml.esqlDataVisualizer.desc', + { + defaultMessage: 'ES|QL data visualizer page', + } +); export const DATA_DRIFT_TITLE = i18n.translate( 'xpack.securitySolution.navLinks.ml.dataDrift.title', { From 209fbfc1a88a08ef1bbfde8d7e6e9a00a30705ee Mon Sep 17 00:00:00 2001 From: Melissa Date: Thu, 12 Sep 2024 12:49:07 -0600 Subject: [PATCH 2/3] esql datavis should come before data drift. order changed --- .../public/app/solution_navigation/links/sections/ml_links.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts b/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts index 5e6c80a9060c0..9581d1159a4f6 100644 --- a/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts +++ b/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts @@ -85,8 +85,8 @@ export const mlNavCategories: SolutionLinkCategory[] = [ linkIds: [ ExternalPageName.mlFileUpload, ExternalPageName.mlIndexDataVisualizer, - ExternalPageName.mlDataDrift, ExternalPageName.mlESQLdataVisualizer, + ExternalPageName.mlDataDrift, ], }, { From b377b04b2e083e9a22beb207170d470c597810ba Mon Sep 17 00:00:00 2001 From: Melissa Date: Mon, 16 Sep 2024 17:46:35 -0600 Subject: [PATCH 3/3] update esql viz icon --- .../public/app/solution_navigation/links/sections/ml_links.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts b/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts index 1a5b370516724..7a7e7334fefb3 100644 --- a/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts +++ b/x-pack/plugins/security_solution/public/app/solution_navigation/links/sections/ml_links.ts @@ -190,7 +190,7 @@ export const mlNavLinks: SolutionNavLink[] = [ { id: ExternalPageName.mlESQLdataVisualizer, title: i18n.ESQL_DATA_VISUALIZER_TITLE, - landingIcon: IconDataViewLazy, + landingIcon: 'sqlApp', description: i18n.ESQL_DATA_VISUALIZER_DESC, }, {