Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature privilege names to reflect new terminology #95663

Closed
ymao1 opened this issue Mar 29, 2021 · 5 comments · Fixed by #96083
Closed

Update feature privilege names to reflect new terminology #95663

ymao1 opened this issue Mar 29, 2021 · 5 comments · Fixed by #96083
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Mar 29, 2021

As part of #90375, the feature privilege name for Stack Alerts and Alerts Examples should be updated to reflect the new terminology in the UI and any docs that might reference these privileges.

@ymao1 ymao1 added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

++ using the new terminology, I'm guessing it would become Stack Rules but more likely, they should be Stack rule types? @arisonl @gmmorris

@ymao1 ymao1 self-assigned this Mar 30, 2021
@ymao1
Copy link
Contributor Author

ymao1 commented Mar 30, 2021

What about Example Rule Types and Stack Rule Types

Screen Shot 2021-03-30 at 2 27 11 PM

Screen Shot 2021-03-30 at 2 25 38 PM

@gmmorris
Copy link
Contributor

gmmorris commented Apr 6, 2021

++ using the new terminology, I'm guessing it would become Stack Rules but more likely, they should be Stack rule types? @arisonl @gmmorris

I don't know 😬
Do we have some guidance on when it should be rules and when rule types? Have we spoken to @gchaps ?

@arisonl
Copy link
Contributor

arisonl commented Apr 7, 2021

Here are a couple of thoughts:

  • Accuracy: It is clearly a type.
  • Simplicity (UX): Accuracy and UX friendliness may not always go hand-in-hand. For example: ref the privileges screenshot above: The Kibana RBAC privileges model generally secures saved object types, so in this context one could argue that "type" is redundant and "Stack Rules" is simpler and hence better. Furthermore, when you secure a type, you secure the objects of that type, by definition, so omitting the term "type" in this context is "accurate enough".
  • Consistency: How is the same concept treated in the context of the solutions? In addition the previous argument in favour of simplicity in the context of privileges may not apply in the "select rule" vs "select rule type" UI case (are these the only two places where this comes up?)

I would go for consistency and if it's entirely up to us, I would choose the simplest "accurate enough" language to surface on the UI.

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants