-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Upgrade Puppeteer to 8.0.0 #90496
Comments
Pinging @elastic/kibana-app-services (Team:AppServices) |
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
Postpone until @tsullivan looks into automating building of puppeteer. |
It's not completely ready for automation yet, but we should be able to update to 7.10.0 soon which ships with Chromium version 90.
Removing the blocked label from this issue |
mainFrameClipsContent=false
Puppeteer Launch arg
Closed via #98688 |
Puppeteer recently implemented a change that causes any area of the screen to not render unless it is within the viewport.
The solution is to have Reporting resize the viewport large enough so that all the data is rendered. This adversely affects performance because Puppeteer also has stability issues with large viewports. Compensating with large RAM on the system doesn't seem to help.
Chromium / Blink Renderer had a recent change pushed that gives us better options: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629. It gives developers who use Puppeteer the option to add
mainFrameClipsContent=false
in a launch arg - using that restores the old behavior.We should update to a new build of Chromium that has support for that flag, and update to a new version of Puppeteer that supports that version of Chromium.
We should also add a check into the code before resizing the viewport of the headless page, never to size it more than 11 megapixels. If we need to capture an image larger than 11 MP, we can stitch different clips of the page into 1 image: because of the the mainFrameClipsContent option, it can still be captured if the content is "below the fold"
The text was updated successfully, but these errors were encountered: