Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0 only] Alert notifyWhen field should not be nullable #85639

Closed
ymao1 opened this issue Dec 10, 2020 · 3 comments · Fixed by #93977
Closed

[8.0 only] Alert notifyWhen field should not be nullable #85639

ymao1 opened this issue Dec 10, 2020 · 3 comments · Fixed by #93977
Assignees
@mikecote
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Dec 10, 2020

This PR added a new notifyWhen field to Alerts that specifies when an alert should run actions (onActionGroupChange | onActiveAlert | onThrottleInterval). In order to maintain backwards compatibility for users of the alert API, we also allow this field to be null.

To follow up on that PR, we should eventually make this a mandatory field. This would be a breaking change so it could happen for 8.0
@ymao1 ymao1 added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

mikecote commented Feb 5, 2021

Moving from 7.x - Candidates to 7.15/8.0 after the latest 7.x planning session.

@mikecote mikecote changed the title Alert notifyWhen field should not be nullable [8.0 only] Alert notifyWhen field should not be nullable Feb 23, 2021
@mikecote mikecote self-assigned this Mar 16, 2021
@mikecote mikecote mentioned this issue Mar 16, 2021
Merged
7 tasks
@mikecote
Copy link
Contributor

This will be done in the new create rule API where notify_when won't be nullable (#93977 and #93980).

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikecote mikecote

Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create new alerting HTTP APIs that use the new terminology elastic/kibana
4 participants
@kobelb @mikecote @ymao1 @elasticmachine