Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Platform] Expose uiSettings on server side #44994

Closed
8 of 11 tasks
stacey-gammon opened this issue Sep 6, 2019 · 12 comments
Closed
8 of 11 tasks

[New Platform] Expose uiSettings on server side #44994

stacey-gammon opened this issue Sep 6, 2019 · 12 comments
Assignees
Labels
blocked blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@stacey-gammon
Copy link
Contributor

stacey-gammon commented Sep 6, 2019

Plan

Nice to do:

Original post:
uiSettings is available on core in client side, but I think it makes sense to expose a similar service server side. The data plugin could use it, we'd like users to be able to use the search API, and if they leave certain settings off, we'll default to the ones in uiSettings.

cc @lukasolson

@stacey-gammon stacey-gammon added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Sep 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@stacey-gammon
Copy link
Contributor Author

Needed for #29215

@joshdover
Copy link
Contributor

Related: #22779

@flash1293
Copy link
Contributor

Needed for migrating the Graph server APIs

@rudolf
Copy link
Contributor

rudolf commented Sep 23, 2019

There are a couple of existing plugins that would also be blocked by this (graph, siem, infra, dashboard_mode)

The server UISettingsClient will have to be exposed through the request context and use the request scoped SavedObjectsClient so that advanced settings remain space aware.

@joshdover
Copy link
Contributor

@rudolf to be clear, this is blocked by #44143, correct?

@rudolf
Copy link
Contributor

rudolf commented Sep 24, 2019

Correct.

@rudolf rudolf added the blocked label Sep 24, 2019
@mshustov
Copy link
Contributor

As the very first step, we can migrate legacy service to TypeScript. If SavedObjects and Logging with metadata aren't available soon, we can hack and provide legacy service via RequestHandlerContext using Legacy API. There is an example how to make it work in my branch master...restrry:expose-hacked-ui-settings

@joshdover
Copy link
Contributor

We haven't prioritized logging metadata very high in our backlog. Maybe we need to re-evaluate? Do you know what else needs that feature?

@mshustov
Copy link
Contributor

mshustov commented Sep 26, 2019

We haven't prioritized logging metadata very high in our backlog. Maybe we need to re-evaluate? Do you know what else needs that feature?

Only Security & Spaces plugins waits for it, other calls are done by the platform & optimizer.
All in all, it shouldn't take a lot of time to add metadata support. If it can be done in a day or so, we can prioritize it higher.

@mshustov
Copy link
Contributor

minimum functionality is implemented. possible improvements are moved to #48925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

6 participants