Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample workpads look wrong #29893

Closed
w33ble opened this issue Feb 2, 2019 · 6 comments · Fixed by #30747
Closed

Sample workpads look wrong #29893

w33ble opened this issue Feb 2, 2019 · 6 comments · Fixed by #30747
Assignees
Labels
bug Fixes for quality problems that affect the customer experience PR sent Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.0.0

Comments

@w33ble
Copy link
Contributor

w33ble commented Feb 2, 2019

Kibana version: b71b815 or newer, and I think only in master/7.0

Original install method (e.g. download page, yum, from source, etc.): Clone repo

Describe the bug:

Some time in the last few days (between 8b89248 and b71b815), some font changes landed that affect all workpads, including the sample workpads. Because the font change affects text sizing, some text is now cut off or wrapping unexpectedly.

Steps to reproduce:

  1. Make sure you are using b71b815 or newer
  2. Load some sample data
  3. Open the associated sample workpad(s)

Screenshots (if relevant):

WebLogs Before (via 8b89248)

screenshot 2019-02-01 17 13 33

Note: Ignore that broken chart, that's been fixed in #29537

WebLogs After (via b71b815)

screenshot 2019-02-01 16 59 21

@w33ble w33ble added bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Feb 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@snide
Copy link
Contributor

snide commented Feb 2, 2019

Yep, that's why we labeled it a breaking change and only applied it only to 7. Canvas will need to adjust the bounding boxes on the template meta data for any pre-built dashboards to account for the changes.

@snide
Copy link
Contributor

snide commented Feb 2, 2019

Oh wow, I just assumed this was from my PR. If it's not fantastic :)

Though it still might be us! I'll look into it on monday.

@w33ble
Copy link
Contributor Author

w33ble commented Feb 11, 2019

@snide I think it was the font change. I didn't really intend for y'all to do anything here, since it's a Canvas concern, but wanted to make you and your team aware. You can remove the Design label if it makes your life easier 😉.

@w33ble
Copy link
Contributor Author

w33ble commented Feb 11, 2019

This only seems to affect the sample web traffic workpad. The other two look fine with the increased font sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience PR sent Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants