Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reporting in Canvas if it's not available #28783

Closed
alexfrancoeur opened this issue Jan 15, 2019 · 7 comments
Closed

Disable reporting in Canvas if it's not available #28783

alexfrancoeur opened this issue Jan 15, 2019 · 7 comments
Labels
Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@alexfrancoeur
Copy link

alexfrancoeur commented Jan 15, 2019

Updated on 1/16/2018

When attempting to export a PDF with a Basic license, we should provide a better UI/UX. It would be nice to have some sort of warning or disabled button for the feature rather than showing an error toast notification.

This is what we were showing if you were using chromium (https://github.com/elastic/kibana-canvas/pull/998)

image

This is what the experience looks like today

image

screen shot 2019-01-15 at 2 55 14 pm

@alexfrancoeur alexfrancoeur added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jan 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@cqliu1
Copy link
Contributor

cqliu1 commented Jan 15, 2019

@alexfrancoeur I don't think this is a regression. Looking at the original PR, it only checks if the reporting browser type is chromium but doesn't check if the license is basic.

We certainly should check the license and display a different disabled reporting dialog.

@alexfrancoeur
Copy link
Author

@cqliu1 you are correct! I'll remove the regression / bug tag and make this more of an ER.

@alexfrancoeur alexfrancoeur changed the title [Regression] Disable reporting in Canvas if it's not available Disable reporting in Canvas if it's not available Jan 16, 2019
@alexfrancoeur alexfrancoeur removed the bug Fixes for quality problems that affect the customer experience label Jan 16, 2019
@alexfrancoeur
Copy link
Author

@ryankeairns would be interested in hearing your thoughts here as well. Might be nice to sneak into 6.7 as a UX improvement.

@ryankeairns
Copy link
Contributor

ryankeairns commented Jan 16, 2019

Presuming we can detect the Basic license, I would recommend we still allow users to get to the Reporting feature (even if it's disabled) in order to raise awareness/interest. Once they open the popover, then they would see a callout like this followed by the regular content (with disabled buttons):

screenshot 2019-01-16 08 07 43

@cqliu1
Copy link
Contributor

cqliu1 commented Jan 16, 2019

Would it be better to just remove PDF Reports as an option in the export context menu if the user is on a basic license?

@cqliu1 cqliu1 added the loe:small Small Level of Effort label Mar 15, 2019
@timductive
Copy link
Member

Closing this issue as duplicate to #26357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

6 participants