Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mappings editor] Use stripUnsetFields option in edit field form #202150

Open
ElenaStoeva opened this issue Nov 28, 2024 · 1 comment
Open

[Mappings editor] Use stripUnsetFields option in edit field form #202150

ElenaStoeva opened this issue Nov 28, 2024 · 1 comment
Assignees
Labels
enhancement New value added to drive a business result Feature:Mappings Editor Index mappings editor UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@ElenaStoeva
Copy link
Contributor

In #152730, we disabled the "Update" button if there are no changes and added a warning that if we update the field, all default values would be added.

Image

This was a short-term solution to a problematic behavior where all default values are automatically added when clicking the "Update" button, even if they were not explicitly set.

Recently, we added a new stripUnsetFields option to the form library that allows only adding modified fields to the request (#194148) and we used it in the Advanced options tab in the Mappings editor. We can use this option for the edit form as well so that we don't have to disable the Update button and display a warning message.

@ElenaStoeva ElenaStoeva added enhancement New value added to drive a business result Feature:Mappings Editor Index mappings editor UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Nov 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@ElenaStoeva ElenaStoeva changed the title [Mappings editor] Enable "Update" button in edit field form even if there are no changes [Mappings editor] Use stripUnsetFields option in edit field form Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Mappings Editor Index mappings editor UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

2 participants