Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Tests for prebuilt rule import/export workflow #202079

Open
5 tasks
Tracked by #174168
banderror opened this issue Nov 27, 2024 · 6 comments
Open
5 tasks
Tracked by #174168

[Security Solution] Tests for prebuilt rule import/export workflow #202079

banderror opened this issue Nov 27, 2024 · 6 comments
Assignees
Labels
8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test test-coverage issues & PRs for improving code test coverage test-plan v8.18.0

Comments

@banderror
Copy link
Contributor

banderror commented Nov 27, 2024

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #174168

Summary

Write test plans (one or a few) and create a comprehensive suite of automated tests for the workflow of exporting and importing prebuilt rules.

Please note that test plans for prebuilt rule export and import have been already written in #191116, and there is already test coverage for that. What I would like us to do is to review the existing plans, the tests, compare them with the cases described in the RFC, think about any other edge cases, audit the existing plans and coverage, and add anything that's missing.

Features to cover:

  • Export
    • Exporting custom, prebuilt customized, and prebuilt non-customized rules
    • Exporting from the Rule Details page
    • Exporting from the Rule Management page (single and bulk export)
  • Import
    • Importing custom, prebuilt customized, and prebuilt non-customized rules
    • Importing from the Rule Management page
    • Importing when prebuilt rules are not installed yet
    • Importing when prebuilt rules are already installed
    • Importing current versions, older versions, newer versions, non-existing versions (edge cases)
    • Importing rules with known and unknown rule_id's (edge cases)
    • Converting custom rules to prebuilt rules on upgrade (edge case)

Please cover both the features under the feature flag turned ON and OFF.

Related tickets

Related functional tickets to cover with tests:

Related bugs to cover with tests:

TODO

  • Come up with a plan for working on this ticket and share with the team
  • Test plans
    • PR link
  • Test coverage
    • PR link
@banderror banderror added 8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team test test-coverage issues & PRs for improving code test coverage test-plan labels Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror changed the title [Security Solution] Tests for prebuilt rule import/export workflow (DRAFT) [Security Solution] Tests for prebuilt rule import/export workflow Nov 27, 2024
@banderror
Copy link
Contributor Author

@jpdjere Please check this ticket and prioritize working on it after #202078. Before writing any tests and test plans, review what we already have and try to plan your work and share the plan with me and the team, so we could give feedback on the scope, approach, etc.

@banderror
Copy link
Contributor Author

cc @pborgonovi

@banderror banderror assigned dplumlee and unassigned jpdjere Dec 2, 2024
@banderror
Copy link
Contributor Author

@jpdjere Just FYI that we discussed with the team that @dplumlee could work on it and would probably start working on it sooner. Reassigned the ticket to Davis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test test-coverage issues & PRs for improving code test coverage test-plan v8.18.0
Projects
None yet
Development

No branches or pull requests

4 participants