Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Tests for prebuilt rule customization workflow #202068

Open
5 tasks
Tracked by #174168
banderror opened this issue Nov 27, 2024 · 5 comments
Open
5 tasks
Tracked by #174168

[Security Solution] Tests for prebuilt rule customization workflow #202068

banderror opened this issue Nov 27, 2024 · 5 comments
Assignees
Labels
8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test test-coverage issues & PRs for improving code test coverage test-plan v8.18.0

Comments

@banderror
Copy link
Contributor

banderror commented Nov 27, 2024

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #174168

Summary

Write test plans (one or a few) and create a comprehensive suite of automated tests for the workflow of customizing prebuilt rules.

Features to cover:

  • Editing prebuilt rules (actions as a whole)
    • from the Rule Details page
    • from the Rule Management page (single edit via the context menu)
    • from the Rule Management page (bulk edit via the bulk actions menu)
      • I think every bulk editing action should be smoke tested
  • Calculating the is_customized field and the Modified badge in the UI
  • Editing prebuilt rules and calculating is_customized - per each rule field - in API and UI
    • name
    • description
    • etc - I feel that we need to cover literally every rule field

Please cover both the features under the feature flag turned ON and OFF.

Related tickets

Related functional tickets to cover with tests:

Related bugs to cover with tests:

TODO

  • Come up with a plan for working on this ticket and share with the team
  • Test plans
    • PR link
  • Test coverage
    • PR link
@banderror banderror added 8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team test test-coverage issues & PRs for improving code test coverage test-plan labels Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror changed the title [Security Solution] Tests for prebuilt rule customization workflow (DRAFT) [Security Solution] Tests for prebuilt rule customization workflow Nov 27, 2024
@banderror
Copy link
Contributor Author

@dplumlee Please check this ticket and prioritize working on it after bugfixing. Before writing any tests and test plans, try to plan your work and share the plan with me and the team, so we could give feedback on the scope, approach, etc.

@banderror
Copy link
Contributor Author

cc @pborgonovi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test test-coverage issues & PRs for improving code test coverage test-plan v8.18.0
Projects
None yet
Development

No branches or pull requests

3 participants