[APM] Fix inventory plugin link #201122
Merged
[APM] Fix inventory plugin link #201122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
release_note:skip
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
x-pack/plugins/observability_solution/inventory/public/hooks/use_inventory_router.ts
Show resolved
Hide resolved
...y_solution/observability_shared/common/locators/entity_inventory/entity_inventory_locator.ts
Show resolved
Hide resolved
crespocarlos
approved these changes
Nov 21, 2024
kpatticha
approved these changes
Nov 21, 2024
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7459[❌] APM - Cypress: 0/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7461[❌] APM - Cypress: 0/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7462[❌] APM - Cypress: 0/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7463[❌] APM - Cypress: 0/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7465[❌] APM - Cypress: 0/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7466[❌] APM - Cypress: 0/25 tests passed. |
jennypavlova
approved these changes
Nov 26, 2024
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7485[❌] APM - Cypress: 0/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7490[❌] APM - Cypress: 0/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7494[✅] APM - Cypress: 25/25 tests passed. |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 26, 2024
closes elastic#201116 - Fix Inventory locator removing `observability` from the url. - ~~Unify service inventory E2E tests to run it faster avoiding Kibana loading page on every test.~~ - Add test to navigate to the inventory plugin. (cherry picked from commit 4bc9a59)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 26, 2024
closes elastic#201116 - Fix Inventory locator removing `observability` from the url. - ~~Unify service inventory E2E tests to run it faster avoiding Kibana loading page on every test.~~ - Add test to navigate to the inventory plugin. (cherry picked from commit 4bc9a59)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
closes elastic#201116 - Fix Inventory locator removing `observability` from the url. - ~~Unify service inventory E2E tests to run it faster avoiding Kibana loading page on every test.~~ - Add test to navigate to the inventory plugin.
kibanamachine
added a commit
that referenced
this pull request
Nov 26, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[APM] Fix inventory plugin link (#201122)](#201122) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T21:53:48Z","message":"[APM] Fix inventory plugin link (#201122)\n\ncloses https://github.com/elastic/kibana/issues/201116\r\n\r\n- Fix Inventory locator removing `observability` from the url.\r\n- ~~Unify service inventory E2E tests to run it faster avoiding Kibana\r\nloading page on every test.~~\r\n- Add test to navigate to the inventory plugin.","sha":"4bc9a59fcccbe0f58bcb58bbe42fa294dd3f041a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.17.0"],"title":"[APM] Fix inventory plugin link","number":201122,"url":"https://github.com/elastic/kibana/pull/201122","mergeCommit":{"message":"[APM] Fix inventory plugin link (#201122)\n\ncloses https://github.com/elastic/kibana/issues/201116\r\n\r\n- Fix Inventory locator removing `observability` from the url.\r\n- ~~Unify service inventory E2E tests to run it faster avoiding Kibana\r\nloading page on every test.~~\r\n- Add test to navigate to the inventory plugin.","sha":"4bc9a59fcccbe0f58bcb58bbe42fa294dd3f041a"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201122","number":201122,"mergeCommit":{"message":"[APM] Fix inventory plugin link (#201122)\n\ncloses https://github.com/elastic/kibana/issues/201116\r\n\r\n- Fix Inventory locator removing `observability` from the url.\r\n- ~~Unify service inventory E2E tests to run it faster avoiding Kibana\r\nloading page on every test.~~\r\n- Add test to navigate to the inventory plugin.","sha":"4bc9a59fcccbe0f58bcb58bbe42fa294dd3f041a"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cauê Marcondes <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 26, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[APM] Fix inventory plugin link (#201122)](#201122) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T21:53:48Z","message":"[APM] Fix inventory plugin link (#201122)\n\ncloses https://github.com/elastic/kibana/issues/201116\r\n\r\n- Fix Inventory locator removing `observability` from the url.\r\n- ~~Unify service inventory E2E tests to run it faster avoiding Kibana\r\nloading page on every test.~~\r\n- Add test to navigate to the inventory plugin.","sha":"4bc9a59fcccbe0f58bcb58bbe42fa294dd3f041a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.17.0"],"title":"[APM] Fix inventory plugin link","number":201122,"url":"https://github.com/elastic/kibana/pull/201122","mergeCommit":{"message":"[APM] Fix inventory plugin link (#201122)\n\ncloses https://github.com/elastic/kibana/issues/201116\r\n\r\n- Fix Inventory locator removing `observability` from the url.\r\n- ~~Unify service inventory E2E tests to run it faster avoiding Kibana\r\nloading page on every test.~~\r\n- Add test to navigate to the inventory plugin.","sha":"4bc9a59fcccbe0f58bcb58bbe42fa294dd3f041a"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201122","number":201122,"mergeCommit":{"message":"[APM] Fix inventory plugin link (#201122)\n\ncloses https://github.com/elastic/kibana/issues/201116\r\n\r\n- Fix Inventory locator removing `observability` from the url.\r\n- ~~Unify service inventory E2E tests to run it faster avoiding Kibana\r\nloading page on every test.~~\r\n- Add test to navigate to the inventory plugin.","sha":"4bc9a59fcccbe0f58bcb58bbe42fa294dd3f041a"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cauê Marcondes <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
closes elastic#201116 - Fix Inventory locator removing `observability` from the url. - ~~Unify service inventory E2E tests to run it faster avoiding Kibana loading page on every test.~~ - Add test to navigate to the inventory plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #201116
observabilityfrom the url.Unify service inventory E2E tests to run it faster avoiding Kibana loading page on every test.