[Synthetics] Sub-feature for managing private locations !! #201100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:feature
…-loc-sub-feature
…-loc-sub-feature
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This looks great. A small feature with big customer benefit. LGTM |
…-loc-sub-feature
…1/kibana into private-loc-sub-feature
kdelemme
approved these changes
Nov 27, 2024
| @@ -63,7 +63,7 @@ const canManagePrivateLocationsPrivilege: SubFeaturePrivilegeGroupConfig = { | |||
| includeIn: 'all', | |||
| savedObject: { | |||
| all: [privateLocationSavedObjectName, legacyPrivateLocationsSavedObjectName], | |||
| read: [], | |||
| read: [privateLocationSavedObjectName, legacyPrivateLocationsSavedObjectName], | |||
There was a problem hiding this comment.
Do we need these since the parent feature all list them under savedObject.read as well?
There was a problem hiding this comment.
we don't, i think you reviewed outdated, i have already remove those
…-loc-sub-feature
…1/kibana into private-loc-sub-feature
SiddharthMantri
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Privilege changes LGTM.
Couple of questions:
This is a breaking change for users with the previous privileges already assigned, right?Answered in release note section- Can the button to create locations be hidden if a user doesn't have access to do so?
cc: @azasypkin
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 2, 2024
…01100) ## Summary Fixes elastic#200899 Added Synthetics Sub-feature for managing private locations !! User can configure a sub feature in a role under synthetics to allow managing private locations , with role API it will be with ``` { kibana: [ { feature: { uptime: [ 'minimal_all', 'can_manage_private_locations', ], }, spaces: ['*'], }, ], } ``` <img width="1728" alt="image" src="https://github.com/user-attachments/assets/f842da22-9c82-43d0-ad34-c6e19ea187c6"> Create/delete actions on UI will be disabled <img width="1728" alt="image" src="https://github.com/user-attachments/assets/1a164d85-357b-42f3-ae15-0682b2db6c75"> ## Release note If you have already modified sub feature for the synthetics/uptime feature to disable user access for using elastic managed location, addition of this feature means, they will also will not be able to manage(add/delete) private locations. Though this will not impact usage of private locations in monitors. If you want those users to have ability to add/delete new private locations, you can enable that by toggle this feature in role ui or via api. (cherry picked from commit 93eedff)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 2, 2024
…1100) (#202496) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Sub-feature for managing private locations !! (#201100)](#201100) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T14:53:26Z","message":"[Synthetics] Sub-feature for managing private locations !! (#201100)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/200899\r\n\r\nAdded Synthetics Sub-feature for managing private locations !!\r\n\r\nUser can configure a sub feature in a role under synthetics to allow\r\nmanaging private locations ,\r\n\r\nwith role API it will be with \r\n```\r\n{\r\n kibana: [\r\n {\r\n feature: {\r\n uptime: [\r\n 'minimal_all',\r\n 'can_manage_private_locations',\r\n ],\r\n },\r\n spaces: ['*'],\r\n },\r\n ],\r\n }\r\n```\r\n\r\n\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f842da22-9c82-43d0-ad34-c6e19ea187c6\">\r\n\r\nCreate/delete actions on UI will be disabled \r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1a164d85-357b-42f3-ae15-0682b2db6c75\">\r\n\r\n## Release note\r\nIf you have already modified sub feature for the synthetics/uptime\r\nfeature to disable user access for using elastic managed location,\r\naddition of this feature means, they will also will not be able to\r\nmanage(add/delete) private locations. Though this will not impact usage\r\nof private locations in monitors. If you want those users to have\r\nability to add/delete new private locations, you can enable that by\r\ntoggle this feature in role ui or via api.","sha":"93eedff53c8b9c3ebe55dfdb71029336c03542f0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:breaking","v9.0.0","release_note:feature","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.18.0"],"title":"[Synthetics] Sub-feature for managing private locations !!","number":201100,"url":"https://github.com/elastic/kibana/pull/201100","mergeCommit":{"message":"[Synthetics] Sub-feature for managing private locations !! (#201100)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/200899\r\n\r\nAdded Synthetics Sub-feature for managing private locations !!\r\n\r\nUser can configure a sub feature in a role under synthetics to allow\r\nmanaging private locations ,\r\n\r\nwith role API it will be with \r\n```\r\n{\r\n kibana: [\r\n {\r\n feature: {\r\n uptime: [\r\n 'minimal_all',\r\n 'can_manage_private_locations',\r\n ],\r\n },\r\n spaces: ['*'],\r\n },\r\n ],\r\n }\r\n```\r\n\r\n\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f842da22-9c82-43d0-ad34-c6e19ea187c6\">\r\n\r\nCreate/delete actions on UI will be disabled \r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1a164d85-357b-42f3-ae15-0682b2db6c75\">\r\n\r\n## Release note\r\nIf you have already modified sub feature for the synthetics/uptime\r\nfeature to disable user access for using elastic managed location,\r\naddition of this feature means, they will also will not be able to\r\nmanage(add/delete) private locations. Though this will not impact usage\r\nof private locations in monitors. If you want those users to have\r\nability to add/delete new private locations, you can enable that by\r\ntoggle this feature in role ui or via api.","sha":"93eedff53c8b9c3ebe55dfdb71029336c03542f0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201100","number":201100,"mergeCommit":{"message":"[Synthetics] Sub-feature for managing private locations !! (#201100)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/200899\r\n\r\nAdded Synthetics Sub-feature for managing private locations !!\r\n\r\nUser can configure a sub feature in a role under synthetics to allow\r\nmanaging private locations ,\r\n\r\nwith role API it will be with \r\n```\r\n{\r\n kibana: [\r\n {\r\n feature: {\r\n uptime: [\r\n 'minimal_all',\r\n 'can_manage_private_locations',\r\n ],\r\n },\r\n spaces: ['*'],\r\n },\r\n ],\r\n }\r\n```\r\n\r\n\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f842da22-9c82-43d0-ad34-c6e19ea187c6\">\r\n\r\nCreate/delete actions on UI will be disabled \r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1a164d85-357b-42f3-ae15-0682b2db6c75\">\r\n\r\n## Release note\r\nIf you have already modified sub feature for the synthetics/uptime\r\nfeature to disable user access for using elastic managed location,\r\naddition of this feature means, they will also will not be able to\r\nmanage(add/delete) private locations. Though this will not impact usage\r\nof private locations in monitors. If you want those users to have\r\nability to add/delete new private locations, you can enable that by\r\ntoggle this feature in role ui or via api.","sha":"93eedff53c8b9c3ebe55dfdb71029336c03542f0"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
…01100) ## Summary Fixes elastic#200899 Added Synthetics Sub-feature for managing private locations !! User can configure a sub feature in a role under synthetics to allow managing private locations , with role API it will be with ``` { kibana: [ { feature: { uptime: [ 'minimal_all', 'can_manage_private_locations', ], }, spaces: ['*'], }, ], } ``` <img width="1728" alt="image" src="https://github.com/user-attachments/assets/f842da22-9c82-43d0-ad34-c6e19ea187c6"> Create/delete actions on UI will be disabled <img width="1728" alt="image" src="https://github.com/user-attachments/assets/1a164d85-357b-42f3-ae15-0682b2db6c75"> ## Release note If you have already modified sub feature for the synthetics/uptime feature to disable user access for using elastic managed location, addition of this feature means, they will also will not be able to manage(add/delete) private locations. Though this will not impact usage of private locations in monitors. If you want those users to have ability to add/delete new private locations, you can enable that by toggle this feature in role ui or via api.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…01100) ## Summary Fixes elastic#200899 Added Synthetics Sub-feature for managing private locations !! User can configure a sub feature in a role under synthetics to allow managing private locations , with role API it will be with ``` { kibana: [ { feature: { uptime: [ 'minimal_all', 'can_manage_private_locations', ], }, spaces: ['*'], }, ], } ``` <img width="1728" alt="image" src="https://github.com/user-attachments/assets/f842da22-9c82-43d0-ad34-c6e19ea187c6"> Create/delete actions on UI will be disabled <img width="1728" alt="image" src="https://github.com/user-attachments/assets/1a164d85-357b-42f3-ae15-0682b2db6c75"> ## Release note If you have already modified sub feature for the synthetics/uptime feature to disable user access for using elastic managed location, addition of this feature means, they will also will not be able to manage(add/delete) private locations. Though this will not impact usage of private locations in monitors. If you want those users to have ability to add/delete new private locations, you can enable that by toggle this feature in role ui or via api.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…01100) ## Summary Fixes elastic#200899 Added Synthetics Sub-feature for managing private locations !! User can configure a sub feature in a role under synthetics to allow managing private locations , with role API it will be with ``` { kibana: [ { feature: { uptime: [ 'minimal_all', 'can_manage_private_locations', ], }, spaces: ['*'], }, ], } ``` <img width="1728" alt="image" src="https://github.com/user-attachments/assets/f842da22-9c82-43d0-ad34-c6e19ea187c6"> Create/delete actions on UI will be disabled <img width="1728" alt="image" src="https://github.com/user-attachments/assets/1a164d85-357b-42f3-ae15-0682b2db6c75"> ## Release note If you have already modified sub feature for the synthetics/uptime feature to disable user access for using elastic managed location, addition of this feature means, they will also will not be able to manage(add/delete) private locations. Though this will not impact usage of private locations in monitors. If you want those users to have ability to add/delete new private locations, you can enable that by toggle this feature in role ui or via api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #200899
Added Synthetics Sub-feature for managing private locations !!
User can configure a sub feature in a role under synthetics to allow managing private locations ,
with role API it will be with
Create/delete actions on UI will be disabled
Release note
If you have already modified sub feature for the synthetics/uptime feature to disable user access for using elastic managed location, addition of this feature means, they will also will not be able to manage(add/delete) private locations. Though this will not impact usage of private locations in monitors. If you want those users to have ability to add/delete new private locations, you can enable that by toggle this feature in role ui or via api.