Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17] [Inventory][ECO] APM url generated with invalid environment (#200987) #201089

Merged
merged 3 commits into from
Nov 21, 2024
Merged

[8.17] [Inventory][ECO] APM url generated with invalid environment (#200987) #201089

merged 3 commits into from
Nov 21, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

@cauemarcondes
[Inventory][ECO] APM url generated with invalid environment (elastic#…
984fcaa 
…200987)

closes elastic#200913

The service environment can be `null`, when that's the case we should
not pass it to the service locator, we must instead pass `undefined`.

<img width="1238" alt="Screenshot 2024-11-20 at 16 26 18"
src="https://github.com/user-attachments/assets/ced1f3c2-b7e2-4acf-8d87-4e4caa01095c">

(cherry picked from commit dde84ef)
@kibanamachine kibanamachine enabled auto-merge (squash) November 21, 2024 09:20
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine kibanamachine mentioned this pull request Nov 21, 2024
Merged
@cauemarcondes
Copy link
Contributor

buildkite test this

@cauemarcondes
Copy link
Contributor

buildkite test this

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: a3df626
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-201089-a3df62602fb7

History

cc @cauemarcondes

@kibanamachine kibanamachine merged commit b1934ec into elastic:8.17 Nov 21, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@cauemarcondes cauemarcondes

Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @cauemarcondes @elasticmachine