Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update feature privilege docs to reflect new route authorization #201017

Merged

Conversation

SiddharthMantri
Copy link
Contributor

@SiddharthMantri SiddharthMantri commented Nov 20, 2024

Summary

Updates developer documentation on Feature privileges to reflect changes to Route Authorization.

Screenshots

Before
Screenshot 2024-11-20 at 18 52 02

After
Screenshot 2024-11-20 at 18 49 26

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Documentation was added for features that require explanation or tutorials

@SiddharthMantri SiddharthMantri added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v9.0.0 docs DevDocs backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 labels Nov 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@SiddharthMantri SiddharthMantri requested a review from a team November 20, 2024 17:55
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SiddharthMantri SiddharthMantri enabled auto-merge (squash) November 20, 2024 18:39
@SiddharthMantri
Copy link
Contributor Author

@elasticmachine merge upstream

@SiddharthMantri SiddharthMantri added the release_note:skip Skip the PR/issue when compiling release notes label Nov 20, 2024
@SiddharthMantri SiddharthMantri merged commit 4ffdb35 into elastic:main Nov 20, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11941554634

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
…on (elastic#201017)

## Summary

Updates developer documentation on Feature privileges to reflect changes
to Route Authorization.

### Screenshots
Before
<img width="400" alt="Screenshot 2024-11-20 at 18 52 02"
src="https://github.com/user-attachments/assets/0bb01bd0-e41a-48ee-bcaf-bd4119037f1b">

After
<img width="400" alt="Screenshot 2024-11-20 at 18 49 26"
src="https://github.com/user-attachments/assets/2d5712ce-c277-4ecd-831e-750df8309933">

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials

(cherry picked from commit 4ffdb35)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 20, 2024
…rization (#201017) (#201042)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Docs] Update feature privilege docs to reflect new route
authorization (#201017)](#201017)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Sid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T20:52:58Z","message":"[Docs]
Update feature privilege docs to reflect new route authorization
(#201017)\n\n## Summary\r\n\r\nUpdates developer documentation on
Feature privileges to reflect changes\r\nto Route
Authorization.\r\n\r\n\r\n### Screenshots\r\nBefore\r\n<img
width=\"400\" alt=\"Screenshot 2024-11-20 at 18 52
02\"\r\nsrc=\"https://github.com/user-attachments/assets/0bb01bd0-e41a-48ee-bcaf-bd4119037f1b\">\r\n\r\nAfter\r\n<img
width=\"400\" alt=\"Screenshot 2024-11-20 at 18 49
26\"\r\nsrc=\"https://github.com/user-attachments/assets/2d5712ce-c277-4ecd-831e-750df8309933\">\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or
tutorials","sha":"4ffdb35b14c1a19cf0ade972b198a6e6e7f06ba5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","docs","DevDocs","backport:prev-minor","v8.17.0"],"title":"[Docs]
Update feature privilege docs to reflect new route
authorization","number":201017,"url":"https://github.com/elastic/kibana/pull/201017","mergeCommit":{"message":"[Docs]
Update feature privilege docs to reflect new route authorization
(#201017)\n\n## Summary\r\n\r\nUpdates developer documentation on
Feature privileges to reflect changes\r\nto Route
Authorization.\r\n\r\n\r\n### Screenshots\r\nBefore\r\n<img
width=\"400\" alt=\"Screenshot 2024-11-20 at 18 52
02\"\r\nsrc=\"https://github.com/user-attachments/assets/0bb01bd0-e41a-48ee-bcaf-bd4119037f1b\">\r\n\r\nAfter\r\n<img
width=\"400\" alt=\"Screenshot 2024-11-20 at 18 49
26\"\r\nsrc=\"https://github.com/user-attachments/assets/2d5712ce-c277-4ecd-831e-750df8309933\">\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or
tutorials","sha":"4ffdb35b14c1a19cf0ade972b198a6e6e7f06ba5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201017","number":201017,"mergeCommit":{"message":"[Docs]
Update feature privilege docs to reflect new route authorization
(#201017)\n\n## Summary\r\n\r\nUpdates developer documentation on
Feature privileges to reflect changes\r\nto Route
Authorization.\r\n\r\n\r\n### Screenshots\r\nBefore\r\n<img
width=\"400\" alt=\"Screenshot 2024-11-20 at 18 52
02\"\r\nsrc=\"https://github.com/user-attachments/assets/0bb01bd0-e41a-48ee-bcaf-bd4119037f1b\">\r\n\r\nAfter\r\n<img
width=\"400\" alt=\"Screenshot 2024-11-20 at 18 49
26\"\r\nsrc=\"https://github.com/user-attachments/assets/2d5712ce-c277-4ecd-831e-750df8309933\">\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or
tutorials","sha":"4ffdb35b14c1a19cf0ade972b198a6e6e7f06ba5"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sid <[email protected]>
TattdCodeMonkey pushed a commit to TattdCodeMonkey/kibana that referenced this pull request Nov 21, 2024
…on (elastic#201017)

## Summary

Updates developer documentation on Feature privileges to reflect changes
to Route Authorization.


### Screenshots
Before
<img width="400" alt="Screenshot 2024-11-20 at 18 52 02"
src="https://github.com/user-attachments/assets/0bb01bd0-e41a-48ee-bcaf-bd4119037f1b">

After
<img width="400" alt="Screenshot 2024-11-20 at 18 49 26"
src="https://github.com/user-attachments/assets/2d5712ce-c277-4ecd-831e-750df8309933">


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
…on (elastic#201017)

## Summary

Updates developer documentation on Feature privileges to reflect changes
to Route Authorization.


### Screenshots
Before
<img width="400" alt="Screenshot 2024-11-20 at 18 52 02"
src="https://github.com/user-attachments/assets/0bb01bd0-e41a-48ee-bcaf-bd4119037f1b">

After
<img width="400" alt="Screenshot 2024-11-20 at 18 49 26"
src="https://github.com/user-attachments/assets/2d5712ce-c277-4ecd-831e-750df8309933">


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…on (elastic#201017)

## Summary

Updates developer documentation on Feature privileges to reflect changes
to Route Authorization.


### Screenshots
Before
<img width="400" alt="Screenshot 2024-11-20 at 18 52 02"
src="https://github.com/user-attachments/assets/0bb01bd0-e41a-48ee-bcaf-bd4119037f1b">

After
<img width="400" alt="Screenshot 2024-11-20 at 18 49 26"
src="https://github.com/user-attachments/assets/2d5712ce-c277-4ecd-831e-750df8309933">


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) DevDocs docs release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants