Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/diff/calculation/algorithms - multiLineStringDiffAlgorithm if all three versions are different - scenario ABC does not exceed performance limits when diffing and merging extra large input texts #201014

Closed
kibanamachine opened this issue Nov 20, 2024 · 4 comments · Fixed by #201019
Closed

Failing test: Jest Tests.x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/diff/calculation/algorithms - multiLineStringDiffAlgorithm if all three versions are different - scenario ABC does not exceed performance limits when diffing and merging extra large input texts #201014

kibanamachine opened this issue Nov 20, 2024 · 4 comments · Fixed by #201019
Assignees
@banderror
Labels
8.17 candidate failed-test A test failure on a tracked branch, potentially flaky-test Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area legit-flake Test was triaged and marked as an actual flake. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 20, 2024 •
edited
Loading

A test failed on a tracked branch

Error: expect(received).toBeLessThan(expected)

Expected: < 500
Received:   551.849875999993
    at Object.toBeLessThan (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/diff/calculation/algorithms/multi_line_string_diff_algorithm.test.ts:179:35)
    at Promise.then.completed (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:316:40)
    at _runTest (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:121:9)
    at run (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732122682120681691/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Nov 20, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 20, 2024
@kibanamachine kibanamachine added the Team:Detection Rule Management Security Detection Rule Management Team label Nov 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 20, 2024
@banderror banderror added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area legit-flake Test was triaged and marked as an actual flake. 8.17 candidate labels Nov 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror assigned banderror and unassigned dplumlee Nov 20, 2024
@banderror banderror mentioned this issue Nov 20, 2024
Merged
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 20, 2024
@banderror
[Security Solution] Fix flaky test for multiline diff algorithm (elas…
4ed3485 
…tic#201019)

**Fixes: elastic#201014
**Related to:** elastic#199388

## Summary

This PR increases the threshold (time limit) value for the test by 2x
from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness
on CI.

(cherry picked from commit c9e7820)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 20, 2024
@banderror
[Security Solution] Fix flaky test for multiline diff algorithm (elas…
476aa4a 
…tic#201019)

**Fixes: elastic#201014
**Related to:** elastic#199388

## Summary

This PR increases the threshold (time limit) value for the test by 2x
from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness
on CI.

(cherry picked from commit c9e7820)
TattdCodeMonkey pushed a commit to TattdCodeMonkey/kibana that referenced this issue Nov 21, 2024
@banderror @TattdCodeMonkey
[Security Solution] Fix flaky test for multiline diff algorithm (elas…
ec43670 
…tic#201019)

**Fixes: elastic#201014
**Related to:** elastic#199388

## Summary

This PR increases the threshold (time limit) value for the test by 2x
from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness
on CI.
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@banderror @paulinashakirova
[Security Solution] Fix flaky test for multiline diff algorithm (elas…
53f711c 
…tic#201019)

**Fixes: elastic#201014
**Related to:** elastic#199388

## Summary

This PR increases the threshold (time limit) value for the test by 2x
from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness
on CI.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@banderror @CAWilson94
[Security Solution] Fix flaky test for multiline diff algorithm (elas…
101ae53 
…tic#201019)

**Fixes: elastic#201014
**Related to:** elastic#199388

## Summary

This PR increases the threshold (time limit) value for the test by 2x
from 500 ms to 1000 ms. Hope it should be enough to eliminate flakiness
on CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@banderror banderror

Labels
8.17 candidate failed-test A test failure on a tracked branch, potentially flaky-test Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area legit-flake Test was triaged and marked as an actual flake. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Fix flaky test for multiline diff algorithm banderror/kibana
4 participants
@banderror @elasticmachine @kibanamachine @dplumlee