Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Discover] Unskip Discover-Lens functional test suite (#200687) #201013

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Catching an invalid state of properties propagated to the UnifiedHistogram which is using the Lens embeddable in Discover, that causes a rendering error when e.g. ad hoc data views are being edited. Therefore the skipped testview can be unskipped.

(cherry picked from commit e082cd1)
@kibanamachine kibanamachine merged commit e2c0c94 into elastic:8.x Nov 20, 2024
25 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedHistogram 71.3KB 71.4KB +161.0B

cc @kertal

kertal added a commit that referenced this pull request Nov 21, 2024
#201076)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Discover] Unskip Discover-Lens functional test suite
(#200687)](#200687)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthias
Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T17:38:05Z","message":"[Discover]
Unskip Discover-Lens functional test suite (#200687)\n\nCatching an
invalid state of properties propagated to the UnifiedHistogram which is
using the Lens embeddable in Discover, that causes a rendering error
when e.g. ad hoc data views are being edited. Therefore the skipped
testview can be
unskipped.","sha":"e082cd1dfaa79c6fdfc5d7f1d2842b6ca0a5db6c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-major","v8.17.0"],"number":200687,"url":"https://github.com/elastic/kibana/pull/200687","mergeCommit":{"message":"[Discover]
Unskip Discover-Lens functional test suite (#200687)\n\nCatching an
invalid state of properties propagated to the UnifiedHistogram which is
using the Lens embeddable in Discover, that causes a rendering error
when e.g. ad hoc data views are being edited. Therefore the skipped
testview can be
unskipped.","sha":"e082cd1dfaa79c6fdfc5d7f1d2842b6ca0a5db6c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200687","number":200687,"mergeCommit":{"message":"[Discover]
Unskip Discover-Lens functional test suite (#200687)\n\nCatching an
invalid state of properties propagated to the UnifiedHistogram which is
using the Lens embeddable in Discover, that causes a rendering error
when e.g. ad hoc data views are being edited. Therefore the skipped
testview can be
unskipped.","sha":"e082cd1dfaa79c6fdfc5d7f1d2842b6ca0a5db6c"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201013","number":201013,"state":"MERGED","mergeCommit":{"sha":"e2c0c94b52a4fe3486a0e85b84e9856821c27afc","message":"[8.x]
[Discover] Unskip Discover-Lens functional test suite (#200687)
(#201013)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [[Discover] Unskip Discover-Lens functional test
suite\n(#200687)](https://github.com/elastic/kibana/pull/200687)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Matthias\nWilhelm\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-20T17:38:05Z\",\"message\":\"[Discover]\nUnskip
Discover-Lens functional test suite (#200687)\\n\\nCatching an\ninvalid
state of properties propagated to the UnifiedHistogram which is\nusing
the Lens embeddable in Discover, that causes a rendering error\nwhen
e.g. ad hoc data views are being edited. Therefore the skipped\ntestview
can
be\nunskipped.\",\"sha\":\"e082cd1dfaa79c6fdfc5d7f1d2842b6ca0a5db6c\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Feature:Discover\",\"release_note:skip\",\"v9.0.0\",\"Team:DataDiscovery\",\"backport:prev-major\"],\"title\":\"[Discover]\nUnskip
Discover-Lens functional test
suite\n\",\"number\":200687,\"url\":\"https://github.com/elastic/kibana/pull/200687\",\"mergeCommit\":{\"message\":\"[Discover]\nUnskip
Discover-Lens functional test suite (#200687)\\n\\nCatching an\ninvalid
state of properties propagated to the UnifiedHistogram which is\nusing
the Lens embeddable in Discover, that causes a rendering error\nwhen
e.g. ad hoc data views are being edited. Therefore the skipped\ntestview
can
be\nunskipped.\",\"sha\":\"e082cd1dfaa79c6fdfc5d7f1d2842b6ca0a5db6c\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/200687\",\"number\":200687,\"mergeCommit\":{\"message\":\"[Discover]\nUnskip
Discover-Lens functional test suite (#200687)\\n\\nCatching an\ninvalid
state of properties propagated to the UnifiedHistogram which is\nusing
the Lens embeddable in Discover, that causes a rendering error\nwhen
e.g. ad hoc data views are being edited. Therefore the skipped\ntestview
can
be\nunskipped.\",\"sha\":\"e082cd1dfaa79c6fdfc5d7f1d2842b6ca0a5db6c\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Matthias Wilhelm <[email protected]>"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants