Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][UnifiedHistogram] Remove exception preventing code when rendering the chart #200986

Closed
kertal opened this issue Nov 20, 2024 · 2 comments · Fixed by #202117 or #202116
Closed
Assignees
Labels
Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. refactoring Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Nov 20, 2024

In #200687 we added code, to prevent flakiness when the UnifiedHistogram was being rendered in Discover. It was clearly reproduceable, that the following action led to an exception when rendering the UnifiedHistogram which is using the Lens Embeddable.

  • Install all sample data.
  • On Discover page, create an ad hoc data view kib* with @timetamp as the time field.
  • Edit data view and set timestamp as the time field.
  • Edit again and remove the time field.
  • Edit again and set timestamp as the time field.
  • This caused the histogram to fail, but this should no longer be the case

The code added in #200687 was safeguarding the given exception, which appeared to be the most reliable of multiple approaches. But it didn't target the root cause, which appears to be a race condition in the way the required properties were passed in the component.

However it should be removed once possible, which could be done after a refactoring of the UnifiedHistogram or even when #186642 was merged (which refactors large parts of the code)

@kertal kertal added Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. refactoring Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. refactoring Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
3 participants