Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObsUX] All usage of color palette tokens and functions now pull from the theme, and correctly update to use new colors when the theme changes from Borealis to Amsterdam and vice versa. #200954

Closed
Tracked by #200580
MiriamAparicio opened this issue Nov 20, 2024 · 1 comment
Closed
Tracked by #200580

[ObsUX] All usage of color palette tokens and functions now pull from the theme, and correctly update to use new colors when the theme changes from Borealis to Amsterdam and vice versa. #200954

MiriamAparicio opened this issue Nov 20, 2024 · 1 comment
Assignees
@MiriamAparicio
Labels
EUI Visual Refresh Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0

Comments

@MiriamAparicio
Copy link
Contributor

MiriamAparicio commented Nov 20, 2024 •
edited
Loading

For reference: #199715

Examples where changes can be applied:
deprecated useEuiBackgroundColor

kibana/x-pack/plugins/observability_solution/profiling/public/components/topn_functions/function_row.tsx

Line 105 in 8ce1c46

const successColor = useEuiBackgroundColor('success');

Change to eui tokens euiTheme.colors.vis:

kibana/x-pack/plugins/observability_solution/infra/public/components/autocomplete_field/suggestion_item.tsx

Line 105 in 8ce1c46

const getEuiIconColor = (theme: any, suggestionType: QuerySuggestionTypes): string => {

kibana/x-pack/plugins/observability_solution/apm/common/service_health_status.ts

Line 37 in 8ce1c46

export function getServiceHealthStatusColor(theme: EuiTheme, status: ServiceHealthStatus) {

They might be more use cases, these are some examples of usage that need to be modified
@MiriamAparicio MiriamAparicio mentioned this issue Nov 20, 2024
Closed
9 tasks
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 20, 2024
@MiriamAparicio MiriamAparicio changed the title (Required) All usage of color palette tokens and functions now pull from the theme, and correctly update to use new colors when the theme changes from Borealis to Amsterdam and vice versa. [ObsUX] All usage of color palette tokens and functions now pull from the theme, and correctly update to use new colors when the theme changes from Borealis to Amsterdam and vice versa. Nov 20, 2024
@MiriamAparicio MiriamAparicio added v9.0.0 Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team EUI Visual Refresh labels Nov 20, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 20, 2024
@MiriamAparicio MiriamAparicio self-assigned this Nov 21, 2024
@MiriamAparicio MiriamAparicio mentioned this issue Nov 21, 2024
Closed
@MiriamAparicio
Copy link
Contributor Author

work done here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiriamAparicio MiriamAparicio

Labels
EUI Visual Refresh Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[obsUx] Usage of color palette tokens pulls from the theme MiriamAparicio/kibana
1 participant
@MiriamAparicio