[Index Management FTR] Improve delete indices test #200941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
ElenaStoeva
added
Team:Kibana Management
💚 Build Succeeded
Metrics [docs]
History
cc @ElenaStoeva |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7455[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group1.ts: 100/100 tests passed. |
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
mattkime
approved these changes
Nov 22, 2024
|
Starting backport for target branches: 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
Closes elastic#192351 Closes elastic#200660 Closes elastic#193599 Closes elastic#192532 ## Summary This PR improves the IM functional test for indices table. In elastic#192351, the failure most likely occurred because the webdriver tried to interact with elements that are no longer in the DOM - in this case the index rows and table. To avoid this, we are adding a try-catch for `StaleElementReferenceError` in the `expectIndexIsDeleted` test helper. In elastic#192351, elastic#20066, and elastic#193599, the error most likely was caused because the check if an index row exists was performed before the row element was removed from the DOM, therefore it was incorrectly failing. To fix this, we are adding a retry so that the check is retried in case it fails. (cherry picked from commit e48ad46)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2024
Closes elastic#192351 Closes elastic#200660 Closes elastic#193599 Closes elastic#192532 ## Summary This PR improves the IM functional test for indices table. In elastic#192351, the failure most likely occurred because the webdriver tried to interact with elements that are no longer in the DOM - in this case the index rows and table. To avoid this, we are adding a try-catch for `StaleElementReferenceError` in the `expectIndexIsDeleted` test helper. In elastic#192351, elastic#20066, and elastic#193599, the error most likely was caused because the check if an index row exists was performed before the row element was removed from the DOM, therefore it was incorrectly failing. To fix this, we are adding a retry so that the check is retried in case it fails. (cherry picked from commit e48ad46)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
…201318) # Backport This will backport the following commits from `main` to `8.17`: - [[Index Management FTR] Improve delete indices test (#200941)](#200941) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T08:46:09Z","message":"[Index Management FTR] Improve delete indices test (#200941)\n\nCloses https://github.com/elastic/kibana/issues/192351\r\nCloses https://github.com/elastic/kibana/issues/200660\r\nCloses https://github.com/elastic/kibana/issues/193599\r\nCloses https://github.com/elastic/kibana/issues/192532\r\n\r\n\r\n## Summary\r\n\r\nThis PR improves the IM functional test for indices table. In\r\nhttps://github.com//issues/192351, the failure most likely\r\noccurred because the webdriver tried to interact with elements that are\r\nno longer in the DOM - in this case the index rows and table. To avoid\r\nthis, we are adding a try-catch for `StaleElementReferenceError` in the\r\n`expectIndexIsDeleted` test helper. In\r\nhttps://github.com//issues/192351,\r\nhttps://github.com//issues/20066, and\r\nhttps://github.com//issues/193599, the error most likely\r\nwas caused because the check if an index row exists was performed before\r\nthe row element was removed from the DOM, therefore it was incorrectly\r\nfailing. To fix this, we are adding a retry so that the check is retried\r\nin case it fails.","sha":"e48ad46f8adcf680e55facca9987cc1813ec52e1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.17.0","v8.18.0"],"title":"[Index Management FTR] Improve delete indices test","number":200941,"url":"https://github.com/elastic/kibana/pull/200941","mergeCommit":{"message":"[Index Management FTR] Improve delete indices test (#200941)\n\nCloses https://github.com/elastic/kibana/issues/192351\r\nCloses https://github.com/elastic/kibana/issues/200660\r\nCloses https://github.com/elastic/kibana/issues/193599\r\nCloses https://github.com/elastic/kibana/issues/192532\r\n\r\n\r\n## Summary\r\n\r\nThis PR improves the IM functional test for indices table. In\r\nhttps://github.com//issues/192351, the failure most likely\r\noccurred because the webdriver tried to interact with elements that are\r\nno longer in the DOM - in this case the index rows and table. To avoid\r\nthis, we are adding a try-catch for `StaleElementReferenceError` in the\r\n`expectIndexIsDeleted` test helper. In\r\nhttps://github.com//issues/192351,\r\nhttps://github.com//issues/20066, and\r\nhttps://github.com//issues/193599, the error most likely\r\nwas caused because the check if an index row exists was performed before\r\nthe row element was removed from the DOM, therefore it was incorrectly\r\nfailing. To fix this, we are adding a retry so that the check is retried\r\nin case it fails.","sha":"e48ad46f8adcf680e55facca9987cc1813ec52e1"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200941","number":200941,"mergeCommit":{"message":"[Index Management FTR] Improve delete indices test (#200941)\n\nCloses https://github.com/elastic/kibana/issues/192351\r\nCloses https://github.com/elastic/kibana/issues/200660\r\nCloses https://github.com/elastic/kibana/issues/193599\r\nCloses https://github.com/elastic/kibana/issues/192532\r\n\r\n\r\n## Summary\r\n\r\nThis PR improves the IM functional test for indices table. In\r\nhttps://github.com//issues/192351, the failure most likely\r\noccurred because the webdriver tried to interact with elements that are\r\nno longer in the DOM - in this case the index rows and table. To avoid\r\nthis, we are adding a try-catch for `StaleElementReferenceError` in the\r\n`expectIndexIsDeleted` test helper. In\r\nhttps://github.com//issues/192351,\r\nhttps://github.com//issues/20066, and\r\nhttps://github.com//issues/193599, the error most likely\r\nwas caused because the check if an index row exists was performed before\r\nthe row element was removed from the DOM, therefore it was incorrectly\r\nfailing. To fix this, we are adding a retry so that the check is retried\r\nin case it fails.","sha":"e48ad46f8adcf680e55facca9987cc1813ec52e1"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2024
…201319) # Backport This will backport the following commits from `main` to `8.x`: - [[Index Management FTR] Improve delete indices test (#200941)](#200941) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T08:46:09Z","message":"[Index Management FTR] Improve delete indices test (#200941)\n\nCloses https://github.com/elastic/kibana/issues/192351\r\nCloses https://github.com/elastic/kibana/issues/200660\r\nCloses https://github.com/elastic/kibana/issues/193599\r\nCloses https://github.com/elastic/kibana/issues/192532\r\n\r\n\r\n## Summary\r\n\r\nThis PR improves the IM functional test for indices table. In\r\nhttps://github.com//issues/192351, the failure most likely\r\noccurred because the webdriver tried to interact with elements that are\r\nno longer in the DOM - in this case the index rows and table. To avoid\r\nthis, we are adding a try-catch for `StaleElementReferenceError` in the\r\n`expectIndexIsDeleted` test helper. In\r\nhttps://github.com//issues/192351,\r\nhttps://github.com//issues/20066, and\r\nhttps://github.com//issues/193599, the error most likely\r\nwas caused because the check if an index row exists was performed before\r\nthe row element was removed from the DOM, therefore it was incorrectly\r\nfailing. To fix this, we are adding a retry so that the check is retried\r\nin case it fails.","sha":"e48ad46f8adcf680e55facca9987cc1813ec52e1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.17.0","v8.18.0"],"title":"[Index Management FTR] Improve delete indices test","number":200941,"url":"https://github.com/elastic/kibana/pull/200941","mergeCommit":{"message":"[Index Management FTR] Improve delete indices test (#200941)\n\nCloses https://github.com/elastic/kibana/issues/192351\r\nCloses https://github.com/elastic/kibana/issues/200660\r\nCloses https://github.com/elastic/kibana/issues/193599\r\nCloses https://github.com/elastic/kibana/issues/192532\r\n\r\n\r\n## Summary\r\n\r\nThis PR improves the IM functional test for indices table. In\r\nhttps://github.com//issues/192351, the failure most likely\r\noccurred because the webdriver tried to interact with elements that are\r\nno longer in the DOM - in this case the index rows and table. To avoid\r\nthis, we are adding a try-catch for `StaleElementReferenceError` in the\r\n`expectIndexIsDeleted` test helper. In\r\nhttps://github.com//issues/192351,\r\nhttps://github.com//issues/20066, and\r\nhttps://github.com//issues/193599, the error most likely\r\nwas caused because the check if an index row exists was performed before\r\nthe row element was removed from the DOM, therefore it was incorrectly\r\nfailing. To fix this, we are adding a retry so that the check is retried\r\nin case it fails.","sha":"e48ad46f8adcf680e55facca9987cc1813ec52e1"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200941","number":200941,"mergeCommit":{"message":"[Index Management FTR] Improve delete indices test (#200941)\n\nCloses https://github.com/elastic/kibana/issues/192351\r\nCloses https://github.com/elastic/kibana/issues/200660\r\nCloses https://github.com/elastic/kibana/issues/193599\r\nCloses https://github.com/elastic/kibana/issues/192532\r\n\r\n\r\n## Summary\r\n\r\nThis PR improves the IM functional test for indices table. In\r\nhttps://github.com//issues/192351, the failure most likely\r\noccurred because the webdriver tried to interact with elements that are\r\nno longer in the DOM - in this case the index rows and table. To avoid\r\nthis, we are adding a try-catch for `StaleElementReferenceError` in the\r\n`expectIndexIsDeleted` test helper. In\r\nhttps://github.com//issues/192351,\r\nhttps://github.com//issues/20066, and\r\nhttps://github.com//issues/193599, the error most likely\r\nwas caused because the check if an index row exists was performed before\r\nthe row element was removed from the DOM, therefore it was incorrectly\r\nfailing. To fix this, we are adding a retry so that the check is retried\r\nin case it fails.","sha":"e48ad46f8adcf680e55facca9987cc1813ec52e1"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
Closes elastic#192351 Closes elastic#200660 Closes elastic#193599 Closes elastic#192532 ## Summary This PR improves the IM functional test for indices table. In elastic#192351, the failure most likely occurred because the webdriver tried to interact with elements that are no longer in the DOM - in this case the index rows and table. To avoid this, we are adding a try-catch for `StaleElementReferenceError` in the `expectIndexIsDeleted` test helper. In elastic#192351, elastic#20066, and elastic#193599, the error most likely was caused because the check if an index row exists was performed before the row element was removed from the DOM, therefore it was incorrectly failing. To fix this, we are adding a retry so that the check is retried in case it fails.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Closes elastic#192351 Closes elastic#200660 Closes elastic#193599 Closes elastic#192532 ## Summary This PR improves the IM functional test for indices table. In elastic#192351, the failure most likely occurred because the webdriver tried to interact with elements that are no longer in the DOM - in this case the index rows and table. To avoid this, we are adding a try-catch for `StaleElementReferenceError` in the `expectIndexIsDeleted` test helper. In elastic#192351, elastic#20066, and elastic#193599, the error most likely was caused because the check if an index row exists was performed before the row element was removed from the DOM, therefore it was incorrectly failing. To fix this, we are adding a retry so that the check is retried in case it fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192351
Closes #200660
Closes #193599
Closes #192532
Summary
This PR improves the IM functional test for indices table. In #192351, the failure most likely occurred because the webdriver tried to interact with elements that are no longer in the DOM - in this case the index rows and table. To avoid this, we are adding a try-catch for
StaleElementReferenceErrorin theexpectIndexIsDeletedtest helper. In #192351, #20066, and #193599, the error most likely was caused because the check if an index row exists was performed before the row element was removed from the DOM, therefore it was incorrectly failing. To fix this, we are adding a retry so that the check is retried in case it fails.