[v9 readiness] Add product header in FTR test #200833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
release_note:skip
TinaHeiligers
added
the
Team:Detection Rule Management
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
|
@jloleysens This PR could be an example of suppressing elasticsearch deprecation warnings. |
TinaHeiligers
changed the title
afharo
approved these changes
Nov 21, 2024
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
jloleysens
reviewed
Nov 22, 2024
...test_suites/detections_response/utils/rules/prebuilt_rules/perform_upgrade_prebuilt_rules.ts
Show resolved
Hide resolved
banderror
reviewed
Nov 25, 2024
There was a problem hiding this comment.
@TinaHeiligers Thank you for submitting this. Could you please elaborate more on what this PR is supposed to fix, specifically, and how it is related to #197110?
Just a couple of things that would be great to clarify:
- Why only the
/internal/detection_engine/prebuilt_rules/upgrade/_performis affected by this change? Should we add the same header to other API calls to our endpoints? - Is there documentation explaining what
x-elastic-product-originis? - My understanding was that the warnings from [Security Solution] Rule Management tests shouldn't access system indices directly #197110 are triggered by attempts to write to saved object indices directly from tests. Not sure I understand how adding that header to an API call would fix this.
|
@bandarr-io this pr isn't needed, we want the deprecation logs to surface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #197110
Elasticsearch has deprecated access to system indices, and is surfaced in the Kibana deprecation logger and in the ES deprecation log (this is viewable in Discover by end users).
We can decide to exclude these from the “digest” because it is counterproductive for Kibana to display deprecation warnings that users cannot resolve.
To improve the user experience, this pull request (PR) effectively suppresses these deprecation logs for the
/internal/detection_engine/prebuilt_rules/upgrade/_performendpoint, allowing users to focus on actionable items.