[Mappings Editor] Follow-up improvement for _source field #200769
Assignees
Labels
enhancement
New value added to drive a business result
Feature:Mappings Editor
Index mappings editor UI
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Comments
ElenaStoeva
added
enhancement
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
6 tasks
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 25, 2024
) Closes elastic#200769 ## Summary This PR is a follow-up to elastic#199854 and it adds the following code improvements: - Replaces Mappings-editor-context-level property `hasEnterpriceLicense` with plugin-context-level `canUseSyntheticSource` property - Adds jest tests to check if the synthetic option is correctly displayed based on license - Improves readability of serializer logic for the source field **How to test:** The same test instructions from elastic#199854 can be followed with a focus on checking that the synthetic option is only available in Enterprise license. (cherry picked from commit 762bb7f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 25, 2024
) Closes elastic#200769 ## Summary This PR is a follow-up to elastic#199854 and it adds the following code improvements: - Replaces Mappings-editor-context-level property `hasEnterpriceLicense` with plugin-context-level `canUseSyntheticSource` property - Adds jest tests to check if the synthetic option is correctly displayed based on license - Improves readability of serializer logic for the source field **How to test:** The same test instructions from elastic#199854 can be followed with a focus on checking that the synthetic option is only available in Enterprise license. (cherry picked from commit 762bb7f)
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this issue
Nov 26, 2024
) Closes elastic#200769 ## Summary This PR is a follow-up to elastic#199854 and it adds the following code improvements: - Replaces Mappings-editor-context-level property `hasEnterpriceLicense` with plugin-context-level `canUseSyntheticSource` property - Adds jest tests to check if the synthetic option is correctly displayed based on license - Improves readability of serializer logic for the source field **How to test:** The same test instructions from elastic#199854 can be followed with a focus on checking that the synthetic option is only available in Enterprise license.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 12, 2024
) Closes elastic#200769 ## Summary This PR is a follow-up to elastic#199854 and it adds the following code improvements: - Replaces Mappings-editor-context-level property `hasEnterpriceLicense` with plugin-context-level `canUseSyntheticSource` property - Adds jest tests to check if the synthetic option is correctly displayed based on license - Improves readability of serializer logic for the source field **How to test:** The same test instructions from elastic#199854 can be followed with a focus on checking that the synthetic option is only available in Enterprise license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a follow-up to #199854, it would be nice to add the following improvements:
canUseSyntheticOptionvariable into the renderApp method - see [Mappings Editor] Add support for synthetic _source #199854 (comment)The text was updated successfully, but these errors were encountered: