[Security Solution][Document Flyout] Fix toggle column missing in timeline #200647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
backport
release_note:fix
v9.0.0
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
requested changes
Nov 18, 2024
💔 Build Failed
Failed CI StepsHistory |
christineweng
force-pushed
the
table-toggle-column
branch
from
29c5a56 to
4c82f50
Compare
I think it was a mistake we missed. I hunted down when the issue was introduced and it was this PR. The commit before things work on timeline and on the explore pages. This commit breaks the logic |
christineweng
force-pushed
the
table-toggle-column
branch
from
b017674 to
b6b79d4
Compare
PhilippeOberti
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Desk tested and it works in the alerts page, in timeline and even in the cases page, both for alerts and events. Code LGTM.
Thanks for fixing this so quickly @christineweng!
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
…eline (elastic#200647) ## Summary Related: elastic#200046 Reenabling toggle columns for events. It was mistakenly excluded in [this refactor](https://github.com/elastic/kibana/pull/190560/files#diff-d9edcdb9ad0f231269f791e8392d2d0fe1d10105c223c89d9f86e546972bc342)  (cherry picked from commit 467d737)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
…eline (elastic#200647) ## Summary Related: elastic#200046 Reenabling toggle columns for events. It was mistakenly excluded in [this refactor](https://github.com/elastic/kibana/pull/190560/files#diff-d9edcdb9ad0f231269f791e8392d2d0fe1d10105c223c89d9f86e546972bc342)  (cherry picked from commit 467d737)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2024
…in timeline (#200647) (#200662) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Document Flyout] Fix toggle column missing in timeline (#200647)](#200647) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T23:44:43Z","message":"[Security Solution][Document Flyout] Fix toggle column missing in timeline (#200647)\n\n## Summary\r\n\r\nRelated: https://github.com/elastic/kibana/issues/200046\r\n\r\nReenabling toggle columns for events. It was mistakenly excluded in\r\n[this\r\nrefactor](https://github.com/elastic/kibana/pull/190560/files#diff-d9edcdb9ad0f231269f791e8392d2d0fe1d10105c223c89d9f86e546972bc342)\r\n\r\n\r\n","sha":"467d7370ad5eafda73a8a6ff39deb29709ade5ae","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:fix","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.17.0","v8.16.1"],"title":"[Security Solution][Document Flyout] Fix toggle column missing in timeline","number":200647,"url":"https://github.com/elastic/kibana/pull/200647","mergeCommit":{"message":"[Security Solution][Document Flyout] Fix toggle column missing in timeline (#200647)\n\n## Summary\r\n\r\nRelated: https://github.com/elastic/kibana/issues/200046\r\n\r\nReenabling toggle columns for events. It was mistakenly excluded in\r\n[this\r\nrefactor](https://github.com/elastic/kibana/pull/190560/files#diff-d9edcdb9ad0f231269f791e8392d2d0fe1d10105c223c89d9f86e546972bc342)\r\n\r\n\r\n","sha":"467d7370ad5eafda73a8a6ff39deb29709ade5ae"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200647","number":200647,"mergeCommit":{"message":"[Security Solution][Document Flyout] Fix toggle column missing in timeline (#200647)\n\n## Summary\r\n\r\nRelated: https://github.com/elastic/kibana/issues/200046\r\n\r\nReenabling toggle columns for events. It was mistakenly excluded in\r\n[this\r\nrefactor](https://github.com/elastic/kibana/pull/190560/files#diff-d9edcdb9ad0f231269f791e8392d2d0fe1d10105c223c89d9f86e546972bc342)\r\n\r\n\r\n","sha":"467d7370ad5eafda73a8a6ff39deb29709ade5ae"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2024
… in timeline (#200647) (#200661) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Document Flyout] Fix toggle column missing in timeline (#200647)](#200647) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T23:44:43Z","message":"[Security Solution][Document Flyout] Fix toggle column missing in timeline (#200647)\n\n## Summary\r\n\r\nRelated: https://github.com/elastic/kibana/issues/200046\r\n\r\nReenabling toggle columns for events. It was mistakenly excluded in\r\n[this\r\nrefactor](https://github.com/elastic/kibana/pull/190560/files#diff-d9edcdb9ad0f231269f791e8392d2d0fe1d10105c223c89d9f86e546972bc342)\r\n\r\n\r\n","sha":"467d7370ad5eafda73a8a6ff39deb29709ade5ae","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:fix","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.17.0","v8.16.1"],"title":"[Security Solution][Document Flyout] Fix toggle column missing in timeline","number":200647,"url":"https://github.com/elastic/kibana/pull/200647","mergeCommit":{"message":"[Security Solution][Document Flyout] Fix toggle column missing in timeline (#200647)\n\n## Summary\r\n\r\nRelated: https://github.com/elastic/kibana/issues/200046\r\n\r\nReenabling toggle columns for events. It was mistakenly excluded in\r\n[this\r\nrefactor](https://github.com/elastic/kibana/pull/190560/files#diff-d9edcdb9ad0f231269f791e8392d2d0fe1d10105c223c89d9f86e546972bc342)\r\n\r\n\r\n","sha":"467d7370ad5eafda73a8a6ff39deb29709ade5ae"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200647","number":200647,"mergeCommit":{"message":"[Security Solution][Document Flyout] Fix toggle column missing in timeline (#200647)\n\n## Summary\r\n\r\nRelated: https://github.com/elastic/kibana/issues/200046\r\n\r\nReenabling toggle columns for events. It was mistakenly excluded in\r\n[this\r\nrefactor](https://github.com/elastic/kibana/pull/190560/files#diff-d9edcdb9ad0f231269f791e8392d2d0fe1d10105c223c89d9f86e546972bc342)\r\n\r\n\r\n","sha":"467d7370ad5eafda73a8a6ff39deb29709ade5ae"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
|
Removing 8.16.1 tag because it didn't make it to the BC cut. Will add .2 when it is available |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…eline (elastic#200647) ## Summary Related: elastic#200046 Reenabling toggle columns for events. It was mistakenly excluded in [this refactor](https://github.com/elastic/kibana/pull/190560/files#diff-d9edcdb9ad0f231269f791e8392d2d0fe1d10105c223c89d9f86e546972bc342) 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related: #200046
Reenabling toggle columns for events. It was mistakenly excluded in this refactor