Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date on Engines overview page #200545

Closed
L1nBra opened this issue Nov 18, 2024 · 2 comments · Fixed by #201768
Closed

[Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date on Engines overview page #200545

L1nBra opened this issue Nov 18, 2024 · 2 comments · Fixed by #201768
Assignees
@alexwizp
Labels
bug Fixes for quality problems that affect the customer experience defect-level-2 Serious UX disruption with workaround deprecated-in-9.0 Feature marked as deprecated in v9.0. This label is used within the a11y project impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team:Search WCAG A

Comments

@L1nBra
Copy link

L1nBra commented Nov 18, 2024 •
edited by bhavyarm
Loading

Description
When user clicks date button it should activate correct action, or open the new page. In this case, all data disappears from the page which is unexpected.

Preconditions
Stateful App Search -> Engines page is opened.
Engine is added.

Steps to reproduce

1.Navigate to Last updated column value.
2.Click on the date itself.
3.Observe the page.

Gif showing the issue
Image

Actual Result

  • All data disappears from the page (page is white).

Expected Result

  • If date should really be a button, then upon activating, accordingly it should open for the user new page/tab or dialog.

Browser console

Image

core.entry.js:16 TypeError: Cannot read properties of undefined (reading 'euiColorEmptyShade')
    at logsShared.chunk.9.js:20:38
    at ge (kbn-ui-shared-deps-npm.dll.js:594:37372)
    at e.generateAndInjectStyles (kbn-ui-shared-deps-npm.dll.js:594:34412)
    at kbn-ui-shared-deps-npm.dll.js:594:40408
    at kbn-ui-shared-deps-npm.dll.js:594:40439
    at x (kbn-ui-shared-deps-npm.dll.js:594:40853)
    at ua (kbn-ui-shared-deps-npm.dll.js:429:59212)
    at Ya (kbn-ui-shared-deps-npm.dll.js:429:67563)
    at ec (kbn-ui-shared-deps-npm.dll.js:429:116895)
    at Pc (kbn-ui-shared-deps-npm.dll.js:429:99736)

kbn-ui-shared-deps-npm.dll.js:429 Uncaught TypeError: Cannot read properties of undefined (reading 'euiColorEmptyShade')
    at logsShared.chunk.9.js:20:38
    at ge (kbn-ui-shared-deps-npm.dll.js:594:37372)
    at e.generateAndInjectStyles (kbn-ui-shared-deps-npm.dll.js:594:34412)
    at kbn-ui-shared-deps-npm.dll.js:594:40408
    at kbn-ui-shared-deps-npm.dll.js:594:40439
    at x (kbn-ui-shared-deps-npm.dll.js:594:40853)
    at ua (kbn-ui-shared-deps-npm.dll.js:429:59212)
    at Ya (kbn-ui-shared-deps-npm.dll.js:429:67563)
    at ec (kbn-ui-shared-deps-npm.dll.js:429:116895)
    at Pc (kbn-ui-shared-deps-npm.dll.js:429:99736)
```




**Kibana Version:** 8.17.0-SNAPSHOT

**OS:** Windows 11 Pro

**Browser:** Chrome Version 130.0.6723.70 (Official Build) (64-bit)

**WCAG or Vendor Guidance (optional)**
 
- Understanding SC 4.1.2: Name, Role, Value (Level A)(https://www.w3.org/WAI/WCAG22/Understanding/name-role-value.html)

Related to:  https://github.com/elastic/search-team/issues/8256
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 18, 2024
@L1nBra L1nBra added WCAG A impact:critical This issue should be addressed immediately due to a critical level of impact on the product. defect-level-2 Serious UX disruption with workaround Team:Search labels Nov 18, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 18, 2024
@alexwizp alexwizp self-assigned this Nov 26, 2024
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 26, 2024
@alexwizp
fix: [Search:AppSearch:Engines page]Data from page disappears after c…
9163357 
…licking on Last updated date

Closes: elastic#200545
@alexwizp alexwizp mentioned this issue Nov 26, 2024
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 26, 2024
@alexwizp
Merge branch 'main' into elastic#200545
284b155
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 26, 2024
@alexwizp
Merge branch 'main' into elastic#200545
1b51bc3
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 26, 2024
@alexwizp
Merge branch 'main' into elastic#200545
e155ec8
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 28, 2024
@alexwizp
Merge branch 'main' into elastic#200545
d20b647
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 2, 2024
@alexwizp
Merge branch 'main' into elastic#200545
33abbba
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 3, 2024
@alexwizp
Merge branch 'main' into elastic#200545
8e05ca7
@alexwizp alexwizp added the deprecated-in-9.0 Feature marked as deprecated in v9.0. This label is used within the a11y project label Dec 5, 2024
@bhavyarm
Copy link
Contributor

bhavyarm commented Dec 6, 2024

This is a bad bug. If you click on last updated column date, you get a blank page.
Image

@bhavyarm bhavyarm changed the title [Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date [Search:AppSearch:Engines page]Data from page disappears after clicking on Last updated date on Engines overview page Dec 6, 2024
@bhavyarm bhavyarm added the bug Fixes for quality problems that affect the customer experience label Dec 6, 2024
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 10, 2024
@alexwizp
Merge branch 'main' into elastic#200545
f021e61
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 10, 2024
@alexwizp
Merge branch 'main' into elastic#200545
4a90c20
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 12, 2024
@alexwizp
Merge branch 'main' into elastic#200545
c701a03
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 12, 2024
@alexwizp
fix: [Search:AppSearch:Engines page]Data from page disappears after c…
01183b7 
…licking on Last updated date (elastic#201768)

Closes: elastic#200545
Closes: [elastic#8911](elastic/search-team#8911)

## Description
When user clicks date button it should activate correct action, or open
the new page. In this case, all data disappears from the page which is
unexpected. Found while testing for accessibility, but applicable to all
users.

## What was changed?:

1. Since LogsStream still uses `euiStyled`, and we use it in multiple
places, we need to set up `EuiThemeProvider` and `CellActionsProvider`.

## Screen:

<img width="1226" alt="image"
src="https://github.com/user-attachments/assets/cab55d3b-b694-4228-a0a2-7cfa9e0ac16d">

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 359ac08)
kibanamachine added a commit that referenced this issue Dec 12, 2024
@kibanamachine @alexwizp
[8.x] fix: [Search:AppSearch:Engines page]Data from page disappears a…
5c3dd15 
…fter clicking on Last updated date (#201768) (#204031)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Search:AppSearch:Engines page]Data from page disappears after
clicking on Last updated date
(#201768)](#201768)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T14:10:06Z","message":"fix:
[Search:AppSearch:Engines page]Data from page disappears after clicking
on Last updated date (#201768)\n\nCloses: #200545\r\nCloses:
[#8911](https://github.com/elastic/search-team/issues/8911)\r\n\r\n##
Description\r\nWhen user clicks date button it should activate correct
action, or open\r\nthe new page. In this case, all data disappears from
the page which is\r\nunexpected. Found while testing for accessibility,
but applicable to all\r\nusers.\r\n\r\n## What was changed?:\r\n\r\n1.
Since LogsStream still uses `euiStyled`, and we use it in
multiple\r\nplaces, we need to set up `EuiThemeProvider` and
`CellActionsProvider`.\r\n\r\n## Screen: \r\n\r\n<img width=\"1226\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cab55d3b-b694-4228-a0a2-7cfa9e0ac16d\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"359ac089de749c792fb1910229e94d5155d67921","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor","ci:project-deploy-observability"],"title":"fix:
[Search:AppSearch:Engines page]Data from page disappears after clicking
on Last updated
date","number":201768,"url":"https://github.com/elastic/kibana/pull/201768","mergeCommit":{"message":"fix:
[Search:AppSearch:Engines page]Data from page disappears after clicking
on Last updated date (#201768)\n\nCloses: #200545\r\nCloses:
[#8911](https://github.com/elastic/search-team/issues/8911)\r\n\r\n##
Description\r\nWhen user clicks date button it should activate correct
action, or open\r\nthe new page. In this case, all data disappears from
the page which is\r\nunexpected. Found while testing for accessibility,
but applicable to all\r\nusers.\r\n\r\n## What was changed?:\r\n\r\n1.
Since LogsStream still uses `euiStyled`, and we use it in
multiple\r\nplaces, we need to set up `EuiThemeProvider` and
`CellActionsProvider`.\r\n\r\n## Screen: \r\n\r\n<img width=\"1226\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cab55d3b-b694-4228-a0a2-7cfa9e0ac16d\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"359ac089de749c792fb1910229e94d5155d67921"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201768","number":201768,"mergeCommit":{"message":"fix:
[Search:AppSearch:Engines page]Data from page disappears after clicking
on Last updated date (#201768)\n\nCloses: #200545\r\nCloses:
[#8911](https://github.com/elastic/search-team/issues/8911)\r\n\r\n##
Description\r\nWhen user clicks date button it should activate correct
action, or open\r\nthe new page. In this case, all data disappears from
the page which is\r\nunexpected. Found while testing for accessibility,
but applicable to all\r\nusers.\r\n\r\n## What was changed?:\r\n\r\n1.
Since LogsStream still uses `euiStyled`, and we use it in
multiple\r\nplaces, we need to set up `EuiThemeProvider` and
`CellActionsProvider`.\r\n\r\n## Screen: \r\n\r\n<img width=\"1226\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cab55d3b-b694-4228-a0a2-7cfa9e0ac16d\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"359ac089de749c792fb1910229e94d5155d67921"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
bug Fixes for quality problems that affect the customer experience defect-level-2 Serious UX disruption with workaround deprecated-in-9.0 Feature marked as deprecated in v9.0. This label is used within the a11y project impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team:Search WCAG A
Projects
None yet
Milestone
No milestone
4 participants
@bhavyarm @elasticmachine @alexwizp @L1nBra