Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search:AppSearch:Engines page]Incorrect total number of options announced for Join our user research... combo box #200542

Closed
L1nBra opened this issue Nov 18, 2024 · 1 comment · Fixed by #200567
Closed

[Search:AppSearch:Engines page]Incorrect total number of options announced for Join our user research... combo box #200542

L1nBra opened this issue Nov 18, 2024 · 1 comment · Fixed by #200567
Assignees
@alexwizp
Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A

Comments

@L1nBra
Copy link

L1nBra commented Nov 18, 2024 •
edited
Loading

Description
Visible total number of options should the same as announced for the user as not to confuse them. Especially for the users using assistive technologies.

Preconditions
Stateful App Search -> Engines page is opened.
No engine is added.
Use Screen Reader (NVDA).

Steps to reproduce

1.Using only keyboard Navigate to Join our user research... combo box by pressing Tab key.
2.Press Enter.
3.Navigate through options in the opened list.
4.Observe combo box and screen reader announcement.

UI elements + NVDA Speech Viewer
Image

Actual Result

  • Join our user research... combo box has 2 visible options, but it is announced as "of 3".

Expected Result

  • For Join our research... it should be announced "of 2".

Meta Issue

Kibana Version: 8.17.0-SNAPSHOT

OS: Windows 11 Pro

Browser: Chrome Version 130.0.6723.70 (Official Build) (64-bit)

Screen reader: NVDA

WCAG or Vendor Guidance (optional)

Related to: https://github.com/elastic/search-team/issues/8256
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 18, 2024
@L1nBra L1nBra added WCAG A Team:Search defect-level-3 Moderate UX disruption or potentially confusing labels Nov 18, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 18, 2024
@alexwizp alexwizp self-assigned this Nov 18, 2024
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 18, 2024
@alexwizp
fix: [Search:AppSearch:Engines page]Incorrect total number of options…
03b183b 
… announced for Join our user research... combo box

Closes: elastic#200542
@alexwizp alexwizp mentioned this issue Nov 18, 2024
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 20, 2024
@alexwizp
Merge branch 'main' into elastic#200542
66dd8de
alexwizp added a commit that referenced this issue Nov 21, 2024
@alexwizp
fix: [Search:AppSearch:Engines page]Incorrect total number of options…
c145ba1 
… announced for Join our user research... combo box (#200567)

Closes: #200542

## Description
Visible total number of options should the same as announced for the
user as not to confuse them. Especially for the users using assistive
technologies.

## What was changed: 
1. `EuiSelect`.`hasNoInitialSelection` attribute should be set to true
only in case of no default value.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 21, 2024
@alexwizp
fix: [Search:AppSearch:Engines page]Incorrect total number of options…
c6efb91 
… announced for Join our user research... combo box (elastic#200567)

Closes: elastic#200542

## Description
Visible total number of options should the same as announced for the
user as not to confuse them. Especially for the users using assistive
technologies.

## What was changed:
1. `EuiSelect`.`hasNoInitialSelection` attribute should be set to true
only in case of no default value.

(cherry picked from commit c145ba1)
kibanamachine added a commit that referenced this issue Nov 21, 2024
@kibanamachine @alexwizp
[8.x] fix: [Search:AppSearch:Engines page]Incorrect total number of o…
52e8b0f 
…ptions announced for Join our user research... combo box (#200567) (#201198)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Search:AppSearch:Engines page]Incorrect total number of options
announced for Join our user research... combo box
(#200567)](#200567)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T14:12:42Z","message":"fix:
[Search:AppSearch:Engines page]Incorrect total number of options
announced for Join our user research... combo box (#200567)\n\nCloses:
#200542\r\n\r\n## Description\r\nVisible total number of options should
the same as announced for the\r\nuser as not to confuse them. Especially
for the users using assistive\r\ntechnologies.\r\n\r\n## What was
changed: \r\n1. `EuiSelect`.`hasNoInitialSelection` attribute should be
set to true\r\nonly in case of no default
value.","sha":"c145ba1bbc9c47e06d712792d0cd3dcb08fc5218","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Search:AppSearch:Engines page]Incorrect total number of options
announced for Join our user research... combo
box","number":200567,"url":"https://github.com/elastic/kibana/pull/200567","mergeCommit":{"message":"fix:
[Search:AppSearch:Engines page]Incorrect total number of options
announced for Join our user research... combo box (#200567)\n\nCloses:
#200542\r\n\r\n## Description\r\nVisible total number of options should
the same as announced for the\r\nuser as not to confuse them. Especially
for the users using assistive\r\ntechnologies.\r\n\r\n## What was
changed: \r\n1. `EuiSelect`.`hasNoInitialSelection` attribute should be
set to true\r\nonly in case of no default
value.","sha":"c145ba1bbc9c47e06d712792d0cd3dcb08fc5218"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200567","number":200567,"mergeCommit":{"message":"fix:
[Search:AppSearch:Engines page]Incorrect total number of options
announced for Join our user research... combo box (#200567)\n\nCloses:
#200542\r\n\r\n## Description\r\nVisible total number of options should
the same as announced for the\r\nuser as not to confuse them. Especially
for the users using assistive\r\ntechnologies.\r\n\r\n## What was
changed: \r\n1. `EuiSelect`.`hasNoInitialSelection` attribute should be
set to true\r\nonly in case of no default
value.","sha":"c145ba1bbc9c47e06d712792d0cd3dcb08fc5218"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@alexwizp @paulinashakirova
fix: [Search:AppSearch:Engines page]Incorrect total number of options…
a72936d 
… announced for Join our user research... combo box (elastic#200567)

Closes: elastic#200542

## Description
Visible total number of options should the same as announced for the
user as not to confuse them. Especially for the users using assistive
technologies.

## What was changed: 
1. `EuiSelect`.`hasNoInitialSelection` attribute should be set to true
only in case of no default value.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@alexwizp @CAWilson94
fix: [Search:AppSearch:Engines page]Incorrect total number of options…
30e5431 
… announced for Join our user research... combo box (elastic#200567)

Closes: elastic#200542

## Description
Visible total number of options should the same as announced for the
user as not to confuse them. Especially for the users using assistive
technologies.

## What was changed: 
1. `EuiSelect`.`hasNoInitialSelection` attribute should be set to true
only in case of no default value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A
Projects
None yet
Milestone
No milestone
3 participants
@elasticmachine @alexwizp @L1nBra