Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React does not recognize the isCollapsible prop on a DOM element error #200219

Closed
PhilippeOberti opened this issue Nov 8, 2024 · 4 comments · Fixed by #201823
Closed

React does not recognize the isCollapsible prop on a DOM element error #200219

PhilippeOberti opened this issue Nov 8, 2024 · 4 comments · Fixed by #201823
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@PhilippeOberti
Copy link
Contributor

Describe the bug
The error appears in the console React does not recognize the isCollapsible prop on a DOM element.

Impact and severity
No user impact and probably very low priority, though should be a straightforward error the fix.

Environment and versions

  • EUI version: 97.3.0
  • React version: ^17.0.2
  • Kibana version (if applicable): this is happening on Kibana main branch currently (at the time of the creation of this ticket), so 8.16
  • Browser: Chrome
  • Operating System: MacOS

To Reproduce
Steps to reproduce the behavior:

  1. Enable the space-specific Security navigation (Manage spaces => Default => Select solution view => Security)
  2. Navigate to any page with the Security Solution application

Changing the navigation back to Classic makes the error go away.

Expected behavior
The console error should not be thrown.

Screenshots
Image

Additional context
I tried looking at some of the EUI components that could have been at fault here:

@PhilippeOberti PhilippeOberti added the bug Fixes for quality problems that affect the customer experience label Nov 8, 2024
@cee-chen
Copy link
Contributor

cee-chen commented Nov 12, 2024

Likely an issue with EuiCollapsibleNavBeta if switching to Classic fixes the problem. May also be an issue with Kibana's implementation of EuiCollapsibleNavBeta

@cee-chen
Copy link
Contributor

cee-chen commented Nov 14, 2024

After taking a closer look, this is almost certainly an issue in Kibana itself / with the Shared UX implementation of serverless nav, not in the underlying EUI components. Can you transfer this issue to the Kibana repo? cc @sebelga @tsullivan

From what I can tell from the the stacktrace posted, it indicates that an isCollapsible key is getting passed to the accordionProps object which means it needs to be extracted from accordionProps before the rest of the spread is passed down to the component.

That issue is likely here:

const updated: Partial<EuiAccordionProps & { isCollapsible?: boolean }> = {

@cee-chen cee-chen removed their assignment Nov 14, 2024
@sebelga sebelga self-assigned this Nov 14, 2024
@sebelga
Copy link
Contributor

sebelga commented Nov 14, 2024

I'll look into it 👍

@cee-chen cee-chen transferred this issue from elastic/eui Nov 14, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 14, 2024
@mbondyra mbondyra added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Nov 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 15, 2024
sebelga added a commit to sebelga/kibana that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants