[Security solution] Knowledge base unit tests #200207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
Team:Security Generative AI
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
...c_assistant/server/ai_assistant_data_clients/knowledge_base/get_knowledge_base_entry.test.ts
Outdated
Show resolved
Hide resolved
...ck/plugins/elastic_assistant/server/routes/knowledge_base/entries/bulk_actions_route.test.ts
Show resolved
Hide resolved
andrew-goldstein
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Thank you @stephmilovic for improving the test coverage 🙏
LGTM 🚀
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Nov 18, 2024
(cherry picked from commit d57e3b0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stephmilovic
added a commit
that referenced
this pull request
Nov 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Security solution] Knowledge base unit tests (#200207)](#200207) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T20:13:58Z","message":"[Security solution] Knowledge base unit tests (#200207)","sha":"d57e3b0ea0a1b47975f317f48c6a4907702edf3e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.17.0"],"number":200207,"url":"https://github.com/elastic/kibana/pull/200207","mergeCommit":{"message":"[Security solution] Knowledge base unit tests (#200207)","sha":"d57e3b0ea0a1b47975f317f48c6a4907702edf3e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200207","number":200207,"mergeCommit":{"message":"[Security solution] Knowledge base unit tests (#200207)","sha":"d57e3b0ea0a1b47975f317f48c6a4907702edf3e"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves unit test coverage for the new knowledge base feature