[Discover] mailto links in data view urls #200070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghudgins
added
release_note:skip
ghudgins
force-pushed
the
179773/mailto-papercut
branch
from
3d84303 to
93c1844
Compare
ghudgins
changed the title
ghudgins
changed the title
💚 Build Succeeded
Metrics [docs]Page load bundle
|
kertal
added
the
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
akowalska622
approved these changes
Nov 14, 2024
|
@ghudgins you just want this for 9.0? |
|
ah, didn't realize skipping backporting would only do 9.0. yes, would be nice to have in 8.17 if possible. can wait otherwise |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ghudgins
added a commit
to ghudgins/kibana
that referenced
this pull request
Nov 14, 2024
Adds `mailto:` as an allowed URL Url formatters in data views. (cherry picked from commit d7a913f)
11 tasks
ghudgins
added a commit
that referenced
this pull request
Nov 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Discover] mailto links in data view urls (#200070)](#200070) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Graham Hudgins","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-14T13:30:10Z","message":"[Discover] mailto links in data view urls (#200070)\n\nAdds `mailto:` as an allowed URL Url formatters in data views.","sha":"d7a913f183cfe35efe7f42bb2d46990abc07296d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","Team:DataDiscovery"],"number":200070,"url":"https://github.com/elastic/kibana/pull/200070","mergeCommit":{"message":"[Discover] mailto links in data view urls (#200070)\n\nAdds `mailto:` as an allowed URL Url formatters in data views.","sha":"d7a913f183cfe35efe7f42bb2d46990abc07296d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200070","number":200070,"mergeCommit":{"message":"[Discover] mailto links in data view urls (#200070)\n\nAdds `mailto:` as an allowed URL Url formatters in data views.","sha":"d7a913f183cfe35efe7f42bb2d46990abc07296d"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <[email protected]>
wayneseymour
pushed a commit
to wayneseymour/kibana
that referenced
this pull request
Nov 18, 2024
Adds `mailto:` as an allowed URL Url formatters in data views.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Adds `mailto:` as an allowed URL Url formatters in data views.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Adds `mailto:` as an allowed URL Url formatters in data views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
mailto:as an allowed URL Url formatters in data views.Resolves papercut: #179773
Example:
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers