Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Explore - Overview Integration Tests - ESS Env - Trial License.x-pack/test/security_solution_api_integration/test_suites/explore/overview/trial_license_complete_tier/tests/overview_network·ts - @ess @serverless SecuritySolution Explore Overview Overview Network With packetbeat Make sure that we get OverviewNetwork data #199364

Closed
kibanamachine opened this issue Nov 7, 2024 · 6 comments · Fixed by #199539
Closed

Failing test: Explore - Overview Integration Tests - ESS Env - Trial License.x-pack/test/security_solution_api_integration/test_suites/explore/overview/trial_license_complete_tier/tests/overview_network·ts - @ess @serverless SecuritySolution Explore Overview Overview Network With packetbeat Make sure that we get OverviewNetwork data #199364

kibanamachine opened this issue Nov 7, 2024 · 6 comments · Fixed by #199539
Assignees
@davismcphee
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Threat Hunting:Explore

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 7, 2024 •
edited
Loading

A test failed on a tracked branch

Error: retry.try reached timeout 120000 ms
Error: expected 200 "OK", got 400 "Bad Request"
    at block (search.ts:77:10)
    at runAttempt (retry_for_success.ts:30:21)
    at retryForSuccess (retry_for_success.ts:99:27)
    at RetryService.try (retry.ts:52:12)
    at SearchService.send (search.ts:71:20)
    at Context.<anonymous> (overview_network.ts:94:37)
    at Object.apply (wrap_function.js:74:16)
----
    at Test._assertStatus (node_modules/supertest/lib/test.js:252:14)
    at /opt/buildkite-agent/builds/bk-agent-prod-gcp-1731002022759433491/elastic/kibana-on-merge/kibana/node_modules/supertest/lib/test.js:308:13
    at Test._assertFunction (node_modules/supertest/lib/test.js:285:13)
    at Test.assert (node_modules/supertest/lib/test.js:164:23)
    at localAssert (node_modules/supertest/lib/test.js:120:14)
    at fn (node_modules/supertest/lib/test.js:125:7)
    at Test.callback (node_modules/superagent/src/node/index.js:899:3)
    at fn (node_modules/superagent/src/node/index.js:1165:18)
    at IncomingMessage.<anonymous> (node_modules/superagent/src/node/parsers/json.js:19:7)
    at IncomingMessage.emit (node:events:531:35)
    at endReadableNT (node:internal/streams/readable:1696:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at onFailure (retry_for_success.ts:18:9)
    at retryForSuccess (retry_for_success.ts:85:7)
    at RetryService.try (retry.ts:52:12)
    at SearchService.send (search.ts:71:20)
    at Context.<anonymous> (overview_network.ts:94:37)
    at Object.apply (wrap_function.js:74:16)

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Nov 7, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 7, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

mistic added a commit that referenced this issue Nov 8, 2024
@mistic
skip flaky suite (#199364)
63632a6
@davismcphee davismcphee mentioned this issue Nov 8, 2024
Merged
11 tasks
@davismcphee davismcphee self-assigned this Nov 8, 2024
@jbudz jbudz closed this as completed in 116cd9d Nov 8, 2024
mistic added a commit that referenced this issue Nov 8, 2024
@mistic
Revert "skip flaky suite (#199364)"
1a54f28 
This reverts commit 63632a6.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 11, 2024
@mistic @CAWilson94
skip flaky suite (elastic#199364)
b06359c
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 11, 2024
@davismcphee @CAWilson94
Fix missing params from search strategy polling requests causing vali…
6682756 
…dation errors in tests (elastic#199539)

## Summary

This PR fixes an issue introduced in elastic#196962 where search strategy
polling requests sent from some integration tests were missing necessary
body parameters, resulting in validation errors and test failures. This
issue was not caught by CI in the original PR because it only occurs
when a search request runs slow enough to return partial results (and
therefore requires polling), which is not common in test runs.

Fixes elastic#199537
Fixes elastic#199499
Fixes elastic#199460
Fixes elastic#199449
Fixes elastic#199412
Fixes elastic#199410
Fixes elastic#199394
Fixes elastic#199379
Fixes elastic#199372
Fixes elastic#199363
Fixes elastic#199541
Fixes elastic#199446
Fixes elastic#199433
Fixes elastic#199432
Fixes elastic#199381
Fixes elastic#199369
Fixes elastic#199364

Flaky test runner x200:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7362.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 11, 2024
@mistic @CAWilson94
Revert "skip flaky suite (elastic#199364)"
e48dde6 
This reverts commit 63632a6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davismcphee davismcphee

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Threat Hunting:Explore
Projects
None yet
Milestone
No milestone
4 participants
@mistic @elasticmachine @davismcphee @kibanamachine